chore: Dashboard and Web Cleanup components in support of @openstatus/ui package#1972
Open
aggmoulik wants to merge 2 commits intoopenstatusHQ:mainfrom
Open
chore: Dashboard and Web Cleanup components in support of @openstatus/ui package#1972aggmoulik wants to merge 2 commits intoopenstatusHQ:mainfrom
aggmoulik wants to merge 2 commits intoopenstatusHQ:mainfrom
Conversation
|
@aggmoulik is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
…/ui package Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
aggmoulik
force-pushed
the
feature/dashboard-ui-package
branch
from
32ea0fd to
f7df509
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
|
@claude review |
|
Claude Code is working… I'll analyze this and get back to you. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Dashboard and Web apps by removing locally-copied UI components/dependencies and standardizing on the shared @openstatus/ui package.
Changes:
- Remove the Dashboard’s local
sidebarcomponent and switch all consumers to@openstatus/ui/components/ui/sidebar. - Drop
@radix-ui/react-slotfromapps/webdirect dependencies (now provided via@openstatus/ui). - Update
next-env.d.tsroute-types import paths forapps/webandapps/dashboard.
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removes @radix-ui/react-slot from the apps/web importer in the lockfile. |
| apps/web/package.json | Drops direct dependency on @radix-ui/react-slot (relies on @openstatus/ui). |
| apps/web/next-env.d.ts | Updates the route-types import path under .next. |
| apps/dashboard/src/components/ui/sidebar.tsx | Deletes the local sidebar implementation in favor of the shared UI package. |
| apps/dashboard/src/components/nav/workspace-switcher.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/sidebar-right.tsx | Repoints sidebar imports to @openstatus/ui and adjusts import ordering. |
| apps/dashboard/src/components/nav/sidebar-metadata.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/nav-user.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/nav-status-pages.tsx | Repoints sidebar imports to @openstatus/ui (and reorders imports). |
| apps/dashboard/src/components/nav/nav-overview.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/nav-monitors.tsx | Repoints sidebar imports to @openstatus/ui (and reorders imports). |
| apps/dashboard/src/components/nav/nav-main.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/nav-help.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/components/nav/nav-banner-upgrade.tsx | Repoints sidebar imports to @openstatus/ui (and reorders imports). |
| apps/dashboard/src/components/nav/nav-banner-checklist.tsx | Repoints sidebar imports to @openstatus/ui (and reorders imports). |
| apps/dashboard/src/components/nav/app-sidebar.tsx | Repoints sidebar imports to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/status-pages/[id]/status-reports/layout.tsx | Switches SidebarProvider import to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/status-pages/[id]/maintenances/layout.tsx | Switches SidebarProvider import to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/status-pages/[id]/components/layout.tsx | Switches SidebarProvider import to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/monitors/[id]/overview/layout.tsx | Switches SidebarProvider import to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/monitors/[id]/incidents/layout.tsx | Switches SidebarProvider import to @openstatus/ui. |
| apps/dashboard/src/app/(dashboard)/layout.tsx | Switches SidebarProvider/SidebarInset imports to @openstatus/ui. |
| apps/dashboard/next-env.d.ts | Updates the route-types import path under .next. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+19
to
+20
| } from "@openstatus/ui/components/ui/sidebar"; | ||
| import { useSidebar } from "@openstatus/ui/components/ui/sidebar"; |
There was a problem hiding this comment.
useSidebar is imported in a separate statement from the same module as the other sidebar exports. Consider merging these into a single import to avoid duplicate module specifiers and keep the imports easier to maintain.
Suggested change
| } from "@openstatus/ui/components/ui/sidebar"; | |
| import { useSidebar } from "@openstatus/ui/components/ui/sidebar"; | |
| useSidebar, | |
| } from "@openstatus/ui/components/ui/sidebar"; |
Comment on lines
+19
to
+20
| } from "@openstatus/ui/components/ui/sidebar"; | ||
| import { useSidebar } from "@openstatus/ui/components/ui/sidebar"; |
There was a problem hiding this comment.
useSidebar is imported in a separate statement from the same module as the other sidebar exports. Consider merging these into a single import to reduce duplication and simplify future refactors.
Suggested change
| } from "@openstatus/ui/components/ui/sidebar"; | |
| import { useSidebar } from "@openstatus/ui/components/ui/sidebar"; | |
| useSidebar, | |
| } from "@openstatus/ui/components/ui/sidebar"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Dashboard and Web Cleanup components in support of @openstatus/ui package