fix delete highlight crash when search term matches highlight#2796
Draft
fix delete highlight crash when search term matches highlight#2796
Conversation
* fix structure of figure tag * add missing coverage * move nodes to keep any listeners intact * fix figcaption width * actually fix caption width * fix selector * fix vertical selector * make figcaptions match the old layout * snapshots --------- Co-authored-by: staxly[bot] <35789409+staxly[bot]@users.noreply.github.com>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: TylerZeroMaster <33585550+TylerZeroMaster@users.noreply.github.com> Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
Co-authored-by: devops@openstax.org <devops@openstax.org> Co-authored-by: Dante Soares <dante.m.soares@rice.edu>
* announce highlight save status to screen readers * some toast fixes * more fixes * test coverage * use updated message * address generic key feedback * address other feedback * add missing component * address bad spec feedback * address test feedback * fix toasts going behind the header * make a narrower type to prevent the cast * add comment to the clarify why we delay adding the message * snapshots
* trap focus in components * remove shouldFocusCard from useTrapTabNavigation * remove method causing troubles * remove import --------- Co-authored-by: staxly[bot] <35789409+staxly[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-1688