Do not consider extended scan codes in Windows#1357
Merged
mkrnr merged 5 commits intoopensteno:mainfrom Jul 10, 2025
Merged
Conversation
Contributor
|
Thanks a lot for this! I'll do some testing on Windows next days and look into these flags for a code review. |
mkrnr
approved these changes
Jul 2, 2025
Contributor
mkrnr
left a comment
mkrnr
left a comment
There was a problem hiding this comment.
The change looks good to me, thanks a lot!
I was not able to reproduce the original bug with my Windows laptop. I also tested it with the fix and everything works, including function keys.
Member
Author
|
Could it be that some other change between the time the pull request is opened and now happens to already fix the bug? |
Contributor
|
Either that or it only affects some laptops. If it would affect all Windows laptops, we probably would have gotten more complainants over the years. So I'd be cool with merging it anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
(see linked issue.)
Closes #1289 .
Pull Request Checklist
Update: rebased to latest version. Haven't re-tested on Windows though.
Seems difficult to write automatic test for this.