Update macOS launcher to fix missing tray icon#1822
Merged
Conversation
mkrnr
changed the title
dnaq
reviewed
Feb 26, 2026
|
Is this really necessary (having a wrapper binary). Wouldn’t it be possible to have a python entrypoint instead (e.g. using pyinstaller)? |
Contributor
Author
Last time I looked into alternatives like PyInstaller, they all seemed like they would not cover our use cases, especially being able to install packages via pip in our plugins manager. Either way, that would be a huge rewrite that I currently don't have the time for, especially when considering code signing and notarization. For now I just want to fix this menu bar issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes the menu bar icon that was missing since macOS 26.0. This is done be re-writing the app launcher for macOS to directly start the Python process which helps macOS to understand that the Python process belongs to the original process.
Tested on M1 mac and intel mac.
Closes #1768
Pull Request Checklist