Skip to content

Conversation

@skjolber
Copy link

Move parse string table logic to dedicated method.

This allows for parseStringTable(..) overrides in subclass, specificially for interning the strings.

@leonardehrenfried
Copy link
Collaborator

This looks ok but would it not be possible to implement the specialised interning in this repository?

@leonardehrenfried
Copy link
Collaborator

Or extract a specific StringInterner interface for which you can supply your own implementation? I'm a bit hesitant to introduce inheritance if there are alternatives.

@leonardehrenfried
Copy link
Collaborator

Hmm, I just realised that this already relies on inheritance... but maybe we can find a nicer design pattern for this feature.

@skjolber
Copy link
Author

skjolber commented Dec 20, 2025

Later realized could just use Map<ByteString, String> for interning; converting ByteString to String (with toStringUtf8) for new values. So then the strings array could be avoided all together / be of type ByteString instead.

@skjolber skjolber closed this Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants