-
Notifications
You must be signed in to change notification settings - Fork 222
Expand translations for tunnel values
#1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@1ec5 maybe you have an opinion on this (and can review the PR). Testing
|
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
"Building Passage (Highways)" will be quite confusing on |
@ZeLonewolf "highway" refers to both roads and footways in UK English, not US English - right? |
matkoniecz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite confusing on footway building passages
|
Highway in US English refers to higher speed roads specifically. |
|
Brainstorming: |
+1, this seems viable |



I noticed that when picking a tunnel value in the dropdown we don't have a filter that shows only those values that apply to the elected feature – highway vs. waterway.
A quick way around this is, to add the "category" of tunnel to the translation string, like done here.
Wiki: https://wiki.openstreetmap.org/wiki/Key:tunnel
Example current UX:
