-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Nominatim description terms #6533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
config/locales/en.yml
Outdated
| aboriginal_lands: "Aboriginal Lands" | ||
| administrative: "Administrative Boundary" | ||
| census: "Census Boundary" | ||
| low_emission_zone: "Low-emission Zone" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Title case typically capitalizes each part of a hyphenated compound word:
| low_emission_zone: "Low-emission Zone" | |
| low_emission_zone: "Low-Emission Zone" |
config/locales/en.yml
Outdated
| political: "Electoral Boundary" | ||
| postal_code: "Postal Code" | ||
| protected_area: "Protected Area" | ||
| public_transport: "Public Transport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string will appear in front of the name of the feature without any additional modifications, so it should generally be a count noun. “A public transport” would be nonsensical. From the boundary=public_transport documentation, it sounds like “Public Transportation District” would be more descriptive?
config/locales/en.yml
Outdated
| garages: "Garages" | ||
| grass: "Grass" | ||
| greenfield: "Greenfield Land" | ||
| highway: "Highway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this refers to "highway" with the meaning of roadway in general (German: "Fahrbahn"), not to freeway/speedway (German: "Autobahn")
This could be confusing in English too. It suggests that the feature is the highway (or roadway) itself, rather than the land around it. The closest real-world term in American English would be “Road Right of Way”, though it’s legal jargon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well "Road Right of Way" is tortured and to me seems legally wrong because to me the right of way is the bit you have the right to travel along, not land that surrounds it that happens to belong to the highway department. Maybe something like "Highway Land" would do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some legal systems use “road right of way” to mean the whole thing, even the landscaped portions, but we should try to find a better term that’s less prone to regional legal differences. “Road reservation” also comes to mind, but dialects that don’t speak of central reservations won’t have a clue about road reservations.
I guess I can’t think of anything better than “Highway Land”, as weird as it sounds.
config/locales/en.yml
Outdated
| abandoned: "Abandoned Railway" | ||
| buffer_stop: "Buffer Stop" | ||
| construction: "Railway under Construction" | ||
| crossing: "Crossing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not to be confused with highway.crossing, which may be translated completely differently, e. g. German highway.crossing = "Kreuzung", but railway.crossing = "Bahnübergang"
At the same time, this could be confused with railway=level_crossing. The wiki describes it as a pedestrian crossing. iD calls this a “Railway–Path Crossing”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I'd have been inclined to call both a level crossing anyway! Certainly "Railway-Path Crossing" is quite a tortured phrase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. “Pedestrian level crossing” would be ideal, but “level crossing” is shorter. Unlike with presets, we can afford to reuse labels between multiple tags without necessarily warping tag usage.
|
@spixi - I'm not sure if reviewers received notifications after your latest changes, so I'm going to use this comment for a ping and a summary. After the latest changes, the current version of this PR offers the following contested values: I'm going to leave this discussion to the experts 🙂 |
|
There’s some further discussion in the threads above. Coming up with a good label for |
These two are both fine for American-English, but sound very weird to British-English ears. We don't have an equivalent term to "Right of Way" as used by Americans. Additionally, "Right of Way" has a distinct meaning in the UK, which is related to access rights and not landuse. I'd either accept this as-is, or use "Pedestrian Railway Crossing" (i.e. using Pedestrian as a modifier to the term general term Railway Crossing). In summary, I'm fine to merge these as |
I'd like to make a plead again here for using OSM English for the default 'en' terms. If Americanisms are required, they should go into 'en-US'. As a fairly fluent non-native speaker I wouldn't have the faintest idea what a "Road Right Of Way" might be. As a fairly fluent OSMer, I wouldn't even start to guess that this might relate to a The equivalent |
|
As I said above, I’m fine with using an alternative “OSM English” term for If we’re OK with it saying “Highway”, then that’s already the behavior in English, though this would give other localizations an opportunity to translate it to OSM Italian, OSM Thai, etc. Most likely they’d translate it literally. It would likely appear next to the result for the roadway, so a search for a street or an actual highway (e.g., Autobahn) could get confusing. “Road Reservation” is the other option I floated. It sounds very British, but it’s actually an Americanism. 🤔 |


Adds the following Nominatim terms to make them translatable