Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 31, 2025

Bumps the dependencies group with 1 update: make-plural.

Updates make-plural from 7.4.0 to 8.1.0

Release notes

Sourced from make-plural's releases.

make-plural@8.1.0, make-plural-cli@7.4.0, make-plural-compiler@6.1.0

  • Support compact notation (#35)

make-plural@8.0.0

  • Drop make-plural CommonJS exports (#34)

make-plural@7.5.0

  • Update to CLDR v48, adding csw, cv, ie, kok, lld, and sgs locales
Changelog

Sourced from make-plural's changelog.

8.1.0 (2025-12-29)

  • Support compact notation (#35)

8.0.0 (2025-12-28)

⚠ Breaking Changes

  • Drop CommonJS exports (#34)

7.5.0 (2025-12-28)

  • Update to cldr-core v48 (ddd9aed)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 31, 2025
@gravitystorm
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/dependencies-3902acadc6 branch from fa22bb8 to f993bd4 Compare January 7, 2026 15:51
@gravitystorm
Copy link
Collaborator

This PR is cursed somehow, and I'm not sure why. The changes work fine on my local machine, but consistently fail in CI even after rebasing. So I'm not sure what's going on here. Suggestions welcome.

Bumps the dependencies group with 1 update: [make-plural](https://github.com/eemeli/make-plural/tree/HEAD/packages/plurals).


Updates `make-plural` from 7.4.0 to 8.1.0
- [Release notes](https://github.com/eemeli/make-plural/releases)
- [Changelog](https://github.com/eemeli/make-plural/blob/main/packages/plurals/CHANGELOG.md)
- [Commits](https://github.com/eemeli/make-plural/commits/make-plural@8.1.0/packages/plurals)

---
updated-dependencies:
- dependency-name: make-plural
  dependency-version: 8.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/dependencies-3902acadc6 branch from f993bd4 to ab26867 Compare January 8, 2026 01:20
@pablobm
Copy link
Contributor

pablobm commented Jan 9, 2026

I can reproduce running the tests with Docker. It's still fuzzy for me, but I think the JS is failing altogether.

For example, test/system/issues_test.png#test_view_managed_issue fails just after resolving an issue. When I look at the screenshots, I see that everything was ok until the "Resolve" link was clicked. On failure, what the test sees is the development "Routing Error" 404 page complaining that no route matches "[GET] /issues/81/resolve". But that should have been a POST! But it's a "fake" POST triggered from a link with JS, suggesting that the corresponding JS didn't load correctly.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 14, 2026

Looks like make-plural is updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Jan 14, 2026
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/dependencies-3902acadc6 branch January 14, 2026 00:36
@tomhughes
Copy link
Member

So the problem here is that make-plural 8.x has dropped support for anything other then ES6 modules (eemeli/make-plural#34) on the slightly spurious basis that Node can now require an ES6 module which is fine if you're running Node but not so much for loading the code in a browser.

Unfortunately as far I can tell it's completely impossible to use an ES6 module in legacy javascript of the type we use - you can only import a module into another module and none of our top level javascript is currently loaded as a module.

@HolgerJeromin
Copy link
Collaborator

Unfortunately as far I can tell it's completely impossible to use an ES6 module in legacy javascript of the type we use - you can only import a module into another module and none of our top level javascript is currently loaded as a module.

Nope.
The dynamic import is working like a charm to load modules even if the current script is a classic script.
I have no idea how this works with the turbo world though.

@tomhughes
Copy link
Member

That should work probably, but it will mean publishing a separate js resource for make-plural rather than bundling it in application.js with everything else.

@HolgerJeromin
Copy link
Collaborator

I have no idea how the existing bundler will handle my experiment in #6721
Take it as an inspiration :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants