-
Notifications
You must be signed in to change notification settings - Fork 1k
Bump make-plural from 7.4.0 to 8.1.0 in the dependencies group #6664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dependabot rebase |
fa22bb8 to
f993bd4
Compare
|
This PR is cursed somehow, and I'm not sure why. The changes work fine on my local machine, but consistently fail in CI even after rebasing. So I'm not sure what's going on here. Suggestions welcome. |
Bumps the dependencies group with 1 update: [make-plural](https://github.com/eemeli/make-plural/tree/HEAD/packages/plurals). Updates `make-plural` from 7.4.0 to 8.1.0 - [Release notes](https://github.com/eemeli/make-plural/releases) - [Changelog](https://github.com/eemeli/make-plural/blob/main/packages/plurals/CHANGELOG.md) - [Commits](https://github.com/eemeli/make-plural/commits/make-plural@8.1.0/packages/plurals) --- updated-dependencies: - dependency-name: make-plural dependency-version: 8.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
f993bd4 to
ab26867
Compare
|
I can reproduce running the tests with Docker. It's still fuzzy for me, but I think the JS is failing altogether. For example, |
|
Looks like make-plural is updatable in another way, so this is no longer needed. |
|
So the problem here is that make-plural 8.x has dropped support for anything other then ES6 modules (eemeli/make-plural#34) on the slightly spurious basis that Node can now Unfortunately as far I can tell it's completely impossible to use an ES6 module in legacy javascript of the type we use - you can only import a module into another module and none of our top level javascript is currently loaded as a module. |
Nope. |
|
That should work probably, but it will mean publishing a separate js resource for make-plural rather than bundling it in application.js with everything else. |
|
I have no idea how the existing bundler will handle my experiment in #6721 |
Bumps the dependencies group with 1 update: make-plural.
Updates
make-pluralfrom 7.4.0 to 8.1.0Release notes
Sourced from make-plural's releases.
Changelog
Sourced from make-plural's changelog.
Commits
7b4c457chore: Publishba55f6cfeat: Also update .d.ts files for compact notationd5c283bSupport compact notation (#35)0774ae5chore: Publishef180a4feat!: Drop make-plural CommonJS exports (#34)ea9dd9fchore: Publishddd9aedfeat: Update to cldr-core v48Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions