-
Notifications
You must be signed in to change notification settings - Fork 1k
Restrict linkify shorthand expansion to plain text #6674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pablobm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the Markdown versions should still linkify, just not within code blocks. More difficult to implement though, so not for this PR.
|
You know what? I'm splitting this PR. I originally just wanted to get some ideas down while in that headspace, but this is holding up the bug fix. |
tomhughes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new cut down version of this looks good to me, thanks.
Define linkify link detection/expansion rules only in the Text submodule and add a test against it messing up markdown content, which