Skip to content

Conversation

@hlfan
Copy link
Collaborator

@hlfan hlfan commented Jan 4, 2026

Define linkify link detection/expansion rules only in the Text submodule and add a test against it messing up markdown content, which

Copy link
Contributor

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the Markdown versions should still linkify, just not within code blocks. More difficult to implement though, so not for this PR.

@hlfan
Copy link
Collaborator Author

hlfan commented Jan 8, 2026

You know what? I'm splitting this PR. I originally just wanted to get some ideas down while in that headspace, but this is holding up the bug fix.

@hlfan hlfan requested a review from tomhughes January 12, 2026 16:06
Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new cut down version of this looks good to me, thanks.

@tomhughes tomhughes merged commit ee16899 into openstreetmap:master Jan 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undocumented changing of message content Diary comments expanded to include text I did not write Linkify breaks Overpass QL source code blocks

3 participants