chore(ci): version.ts check for release-please #651
Conversation
Include release-please annotation in grep/sed lines, as needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve the compatibility of our CI/CD scripts with the release-please tool. Specifically, I've adjusted the scripts responsible for checking and injecting the application version to properly account for the // x-release-please-version annotation that release-please adds to the version declaration.
Highlights
- CI Version Check Update: I've updated the
scripts/check-version-is.shscript to include the// x-release-please-versionannotation whengreping for the version string inlib/src/version.ts. This ensures that the CI check correctly identifies the version even whenrelease-pleasehas added its comment. - NPM Delivery Script Enhancement: I've modified the
scripts/deliver-to-npm-registry.shscript'ssedcommand. It now correctly handles the// x-release-please-versionannotation when injecting the version intolib/src/version.ts. Additionally, I've switched theseddelimiter from/to|to improve robustness.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates CI scripts to handle the release-please version annotation in lib/src/version.ts. The change to check-version-is.sh is correct. However, the sed command in deliver-to-npm-registry.sh incorrectly removes the annotation when updating the version. I've provided a suggestion to fix this to ensure the release process is not broken for future releases.
|
Include release-please annotation in grep/sed lines, as needed