Skip to content

chore(ci): version.ts check for release-please #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

chore(ci): version.ts check for release-please #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ffe5a6
chore(ci): version.ts check for release-please
dmihalcik-virtru Jun 26, 2025
a537b48
Merge branch 'main' into DSPX-1321-correct-versionts
dmihalcik-virtru Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/check-version-is.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if ! grep --fixed-strings --line-regexp --quiet "version=${expected_version}" "M
exit 1
fi

if ! grep --fixed-strings --line-regexp --quiet "export const version = '${expected_version}';" "lib/src/version.ts"; then
if ! grep --fixed-strings --line-regexp --quiet "export const version = '${expected_version}'; // x-release-please-version" "lib/src/version.ts"; then
if grep --quiet "^export const version" "lib/src/version.ts"; then
echo "::error file=lib/src/version.ts,line=$(sed -n '/export const version/=' lib/src/version.ts)::Incorrect version line, should be setting it to [${expected_version}]"
else
Expand Down
2 changes: 1 addition & 1 deletion scripts/deliver-to-npm-registry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ tag="${2}"

cd lib
file=src/version.ts
if ! sed "s/export const version = \'[^']\{1,\}\';\$/export const version = \'${version}\';/" "${file}" >"${file}.tmp"; then
if ! sed "s|export const version = \'[^']\{1,\}\'; // x-release-please-version\$|export const version = \'${version}\';|" "${file}" >"${file}.tmp"; then
echo "Failed to insert version [${version}] into file [$file]"
exit 1
fi
Expand Down
Loading