Skip to content

fix: signingKey should not be part of the computed hash #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

fix: signingKey should not be part of the computed hash #696

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
060571c
fix: `signingKey` should not be part of the computed hash
mkleene Jul 23, 2025
a0485ca
do not include this property
mkleene Jul 23, 2025
0308826
add a test
mkleene Jul 23, 2025
7a8ec0e
Update assertions.spec.ts
mkleene Jul 23, 2025
a4039fa
format
mkleene Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tdf3/src/assertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export type AssertionPayload = {
* @returns the hexadecimal string representation of the hash
*/
export async function hash(a: Assertion): Promise<string> {
const result = canonicalizeEx(a, { exclude: ['binding', 'hash', 'sign', 'verify'] });
const result = canonicalizeEx(a, { exclude: ['binding', 'hash', 'sign', 'verify', 'signingKey'] });

const hash = await crypto.subtle.digest('SHA-256', new TextEncoder().encode(result));
return hex.encodeArrayBuffer(hash);
Expand Down
Loading