chore: DSPX-1236 allow using proper endpoints for OIDC #707
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ntrevino-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented changes to enhance the flexibility of OIDC authentication by allowing explicit configuration of the OIDC token and user information endpoints. This modification enables the system to connect to OIDC providers that may not adhere to standard endpoint discovery conventions or require custom endpoint paths, providing greater adaptability for various OIDC integration scenarios.
Highlights
- Configurable OIDC Endpoints: I've introduced new optional configuration parameters,
oidcTokenEndpointandoidcUserInfoEndpoint, across the OIDC authentication providers. This allows consumers to explicitly define the token and user info endpoints, rather than relying solely on theoidcOriginto derive them. - Dynamic Endpoint Resolution: The
AccessTokenclass has been updated to store and utilize these new configurable endpoints. This ensures that all token exchange and user information lookup operations will respect the provided custom endpoints, falling back to standard derived paths if not specified. - Provider Integration: All relevant OIDC authentication providers, including
OIDCClientCredentialsProvider,OIDCExternalJwtProvider, andOIDCRefreshTokenProvider, have been updated to accept and propagate these new endpoint configurations, ensuring consistent behavior across different authentication flows.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to configure custom OIDC token and userinfo endpoints, which increases flexibility for different OIDC provider setups. The changes are well-implemented across the different auth providers. I've found one issue related to DPoP proof generation where the HTTP method is incorrect, which could lead to authentication failures when DPoP is enabled.
lib/src/auth/oidc.ts
Outdated
| const headers = { | ||
| ...this.extraHeaders, | ||
| Authorization: `Bearer ${accessToken}`, | ||
| } as Record<string, string>; | ||
| if (this.config.dpopEnabled && this.signingKey) { | ||
| headers.DPoP = await dpopFn(this.signingKey, url, 'POST'); | ||
| headers.DPoP = await dpopFn(this.signingKey, this.userInfoEndpoint, 'POST'); |
There was a problem hiding this comment.
The dpopFn is being called with the HTTP method 'POST', but the subsequent fetch request to the userInfoEndpoint is a GET request (as no method is specified, it defaults to GET). The DPoP specification requires that the htm (HTTP method) claim in the DPoP proof JWT matches the HTTP method of the request it is used in. This mismatch will cause DPoP validation to fail on the server side.
The error message on line 151 also indicates a GET request.
| headers.DPoP = await dpopFn(this.signingKey, this.userInfoEndpoint, 'POST'); | |
| headers.DPoP = await dpopFn(this.signingKey, this.userInfoEndpoint, 'GET'); |
|
No description provided.