New otc-metadata-rework #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YustinaKvr
commented
Jul 11, 2025
YustinaKvr
commented
- Switch to new otc-metadata-rework structure
YustinaKvr
requested review from
LukasCuperDT,
RusselSand,
SebastianGode,
anton-sidelnikov,
sgmv,
tischrei and
vladimirhasko
tischrei
approved these changes
Jul 14, 2025
vladimirhasko
requested changes
Jul 14, 2025
|
|
||
| main(BASE_DIR_REGULAR, BASE_RTC_TABLE, BASE_DOC_TABLE, STYRING_URL_REGULAR) | ||
| main(BASE_DIR_SWISS, f"{BASE_RTC_TABLE}_swiss", f"{BASE_DOC_TABLE}_swiss", STYRING_URL_SWISS) | ||
| main(BASE_DIR_UNIFIED, BASE_RTC_TABLE, BASE_DOC_TABLE, STYRING_URL_REGULAR, target_cloud="eu_de") |
There was a problem hiding this comment.
instead of hardcoding can you dynamically query it from otc-metadata to avoid that in future you need to change it with every new env?
There was a problem hiding this comment.
I don't see need to use var here, because in case of changes, we anyway need to change it, here or in var. But using vars could potentially complicate and confuse either changes or debugging, because implies and rely on using one more tool here. So since this is not a sensitive content and not not changes very often, I'd prefer use explicit path here
vladimirhasko
requested changes
Jul 14, 2025
| page = 1 | ||
|
|
||
| if rtc_table == "repo_title_category": | ||
| org = "docs" |
There was a problem hiding this comment.
also this part can be dynamically fetched from otc-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.