Skip to content

Conversation

Copy link

Copilot AI commented Jul 14, 2025

Summary

This PR fixes an inconsistency in the auto-update-pull-request.yml workflow where it was using non-standard secret and variable names for the otelbot GitHub App configuration.

Changes Made

  • Fixed secret name: Changed OTELBOT_JAVA_INSTRUMENTATION_PRIVATE_KEY to OTELBOT_PRIVATE_KEY to match all other workflows
  • Fixed app-id: Changed hardcoded app-id: 1295839 to ${{ vars.OTELBOT_APP_ID }} to match all other workflows

Context

The migration from opentelemetrybot to otelbot was mostly complete across the repository, but this one workflow file had inconsistent naming that didn't match the standard pattern used by all other workflows:

Before:

- uses: actions/create-github-app-token@df432ceedc7162793a195dd1713ff69aefc7379e
  id: otelbot-token
  with:
    app-id: 1295839
    private-key: ${{ secrets.OTELBOT_JAVA_INSTRUMENTATION_PRIVATE_KEY }}

After:

- uses: actions/create-github-app-token@df432ceedc7162793a195dd1713ff69aefc7379e
  id: otelbot-token
  with:
    app-id: ${{ vars.OTELBOT_APP_ID }}
    private-key: ${{ secrets.OTELBOT_PRIVATE_KEY }}

Verification

  • ✅ All workflows now consistently use ${{ vars.OTELBOT_APP_ID }} for app-id
  • ✅ All workflows now consistently use ${{ secrets.OTELBOT_PRIVATE_KEY }} for private-key
  • ✅ YAML syntax validated
  • ✅ No remaining references to old opentelemetrybot patterns found

This ensures consistency across all GitHub App token generation in the repository's workflows.

Fixes #34.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Migrate from opentelemetrybot to otelbot Fix inconsistency in auto-update-pull-request.yml to use standard otelbot configuration Jul 14, 2025
Copilot AI requested a review from trask July 14, 2025 21:58
Copilot finished work on behalf of trask July 14, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from opentelemetrybot to otelbot

2 participants