Use scalecodec rather than bt-decode for query_multi #152
+6
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
run-bittensor-sdk-tests
thewhaleking
added a commit
to opentensor/bittensor
that referenced
this pull request
Jul 18, 2025
basfroman
approved these changes
Jul 18, 2025
This was referenced Jul 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches edgecases where the storage-key has greater context than bt-decode can handle, such as when the result for a query where
scale_info::180 = "FixedU128"results in a result ofb"\x00".The storagekey is aware of the context that the result should actually be
b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'and so correctly decodes it as
{"bits": 0}rather than raising a ValueError.