Add missing hotkey parameter to test functions #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Test failures due to missing
hotkey
parameter in test functions after PR #45 introduced this required parameter to the main API.Description of the Change
This PR fixes test functions in
test_commit_reveal.py
that were broken after PR #45 added a requiredhotkey
parameter to the commit generation functions. The changes include:hotkey
parameter that matches the new API signature introduced in PR CR Improvements #45async
keyword fromtest_generate_commit_various_tempos
test function that doesn't contain anyawait
callsThere are some remaining test failures when comparing the expected reveal round to the round returned by the
get_encrypt_commit
. These have not been addressed in this pull request because of a lack of understanding of the test behavior.Alternate Designs
The only alternative would have been to make the
hotkey
parameter optional in the main functions, but that would contradict the design decision made in PR #45 wherehotkey
was intentionally made required for security and functionality reasons.Possible Drawbacks
None. This change only fixes broken tests to match the current API - it doesn't change any functionality or introduce new behavior.
Verification Process
hotkey
parameterhotkey
parameter to test function callsasync
keyword from non-awaiting functionRelease Notes
Not applicable - this is a test fix that doesn't affect user-facing functionality.
Branch Acknowledgement
[x] I am acknowledging that I am opening this branch against
staging