Transfers improvements #2993
Merged
Transfers improvements #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basfroman
requested changes
Jul 24, 2025
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
Left a comment.
Also, it would be good to add an e2e test using the new flag in tests/e2e_tests/test_transfer.py
basfroman
previously approved these changes
Jul 25, 2025
basfroman
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors opentensor/btcli#562
Uses different extrinsics depending on what is selected.
Transfer All uses "Balances.transfer_all", with param
keep_alivetoggled depending onkeep_alivearg.Non-Transfer-All with
keep_alive=Falseuses "Balances.transfer_allow_death"Non-Transfer-All with
keep_alive=Trueuses "Balances.transfer_keep_alive"