fix: improve code quality and error handling #3193

wnqqnw19 · 2025-12-05T18:10:29Z

- Remove redundant exception aliases in errors.py
  The redundant aliases (SubstrateRequestException = SubstrateRequestException, etc.)
  were unnecessary since these exceptions are already imported from
  async_substrate_interface.errors. Removed them to clean up the code.

- Fix potential AttributeError in settings.py version parsing
  Added null check for re.match() result before calling .group(0) to prevent
  AttributeError if version string doesn't match expected format. Now raises
  a clear ValueError with descriptive message instead of crashing.

…e 3.1.0 with its hotkeypub changes.

…g (such as is the case with BadOrigin) while retaining the list join for non-strings.

…/bump-bt-wallet Bump bittensor-wallet version

…rror-formatter Format Error with string docs

…t constructors

…ect-parrent-init `LoggingMachine` initialization updated to explicitly call both parent constructors

…ding-in-dynamic-info Fixed `moving_price` conversion from `I96F32` to float

…m/astral-sh/uv/blob/main/CHANGELOG.md#088)

…-crv3-logic Add new CRv4 logic

…ix-test-breakages UV Fix

Update changelog + version

…rand-major-version Major version locks drand

Release/9.9.0

replace error

…/update-type-hints-ws-shutdown-timer Update type hint/docstring for ws_shutdown_timer

…rnance-deadcode Commenting on the test until the new governance come

Bumping scalecodec to 1.2.12

Bumping version 9.12.1 + changelog

Release/v9.12.1

* Use uv pip for e2e dependency installation (opentensor#3109) * improve `subtensor.get_liquidity_list` * update `test_liquidity` (non functional) * add storage_keys * fix unit tests * apply default era.period to all extrinsics * apply default era.period to all subtensor extrinsic calls * fix *do tests * replace sn0 owner keys * Allow python 3.14 (opentensor#3122) * 9.12.2: changelog + version (opentensor#3125) changelog + version --------- Co-authored-by: Roman Chkhaidze <[email protected]> Co-authored-by: Roman <[email protected]>

…w-e2e-tests Improve e2e tests workflow

basfroman

Pls apply comments related changes and pull SDKv10 branch since that one is updated now. Then, I review this PR once more.
Thank you for contribution!

basfroman · 2025-12-07T02:36:28Z

bittensor/core/errors.py

-# redundant aliases
-SubstrateRequestException = SubstrateRequestException
-StorageFunctionNotFound = StorageFunctionNotFound
-BlockNotFound = BlockNotFound
-ExtrinsicNotFound = ExtrinsicNotFound
+# Re-export exceptions from async_substrate_interface for convenience
+# These are already imported above, no need for redundant aliases


Please remove all of this and add __all__ in the end of the file

__all__ = [ "BalanceTypeError", "BalanceUnitMismatchError", "BlacklistedException", "BlockNotFound", "ChainConnectionError", "ChainError", "ChainQueryError", "ChainTransactionError", "DelegateTakeTooHigh", "DelegateTakeTooLow", "DelegateTxRateLimitExceeded", "DuplicateChild", "ExtrinsicNotFound", "HotKeyAccountNotExists", "IdentityError", "InternalServerError", "InvalidChild", "InvalidRequestNameError", "MaxAttemptsException", "MaxSuccessException", "MetadataError", "NominationError", "NonAssociatedColdKey", "NotDelegateError", "NotEnoughStakeToSetChildkeys", "NotRegisteredError", "NotVerifiedException", "PostProcessException", "PriorityException", "ProportionOverflow", "RegistrationError", "RegistrationNotPermittedOnRootSubnet", "RunException", "StakeError", "StorageFunctionNotFound", "SubnetNotExists", "SubstrateRequestException", "SynapseDendriteNoneException", "SynapseException", "SynapseParsingError", "TakeError", "TooManyChildren", "TransferError", "TxRateLimitExceeded", "UnknownSynapseError", "UnstakeError", ]

Okay, I'll do that. Thank you for your feedback

basfroman · 2025-12-07T02:37:48Z

bittensor/core/settings.py

+if _version_match is None:
+    raise ValueError(f"Invalid version format: {__version__}. Expected format: X.Y.Z")
+__version__ = _version_match.group(0)


Essentially, with or without your update, we'll know the version might be broken. But your approach is more obvious. I like it!

Hi @basfroman, thanks for the review!

I've updated my branch with the latest SDKv10

Removed the redundant aliases in errors.py

Added the full all list at the end of the file as requested

Everything should now match your review comments, I think. Let me know if anything else needs adjustment!

basfroman · 2025-12-07T09:04:28Z

bittensor/core/errors.py

+# Re-export exceptions from async_substrate_interface for convenience
+# These are already imported above, no need for redundant aliases


remove comments and fix RP checkers issue

I've removed the comments and PR checkers issues as requested. Thanks for your feedback

I rebased your pr to SDKv10 branch.
I guess you want to re-create the PR for SDKv10 instead of solving the conflicts.

Hi @basfroman thanks for rebasing!
I've created a fresh PR #3198 [ Fix/code quality improvements sdkv10 ] targeting SDKv10 as you suggested.

Roman and others added 30 commits August 7, 2025 12:15

update async extrinsic

1ab7491

update e2e test

d3ed298

fix unit tests

e90c412

update requirements

e30dbc5

Bump bittensor-wallet version so people are less likely to install th…

fc47323

…e 3.1.0 with its hotkeypub changes.

Improves the error formatter for instances where the docs are a strin…

198d5ab

…g (such as is the case with BadOrigin) while retaining the list join for non-strings.

Merge pull request opentensor#3005 from opentensor/chore/thewhaleking…

0e4ef47

…/bump-bt-wallet Bump bittensor-wallet version

Merge pull request opentensor#3006 from opentensor/fix/thewhaleking/e…

e51ad47

…rror-formatter Format Error with string docs

Merge branch 'staging' into feat/roman/add-new-crv3-logic

c5b5e41

LoggingMachine initialization updated to explicitly call both paren…

4a14322

…t constructors

fix uv version

639cb66

Merge pull request opentensor#3008 from opentensor/fix/roman/add-corr…

1ed62d3

…ect-parrent-init `LoggingMachine` initialization updated to explicitly call both parent constructors

Fixed moving_price conversion from I96F32 to float

ec65276

Merge pull request opentensor#3010 from mcjkula/fix/moving-price-deco…

11df0e8

…ding-in-dynamic-info Fixed `moving_price` conversion from `I96F32` to float

uv is broken for 0.8 < python 3.10 until 0.8.8 (see https://github.co…

81af4fd

…m/astral-sh/uv/blob/main/CHANGELOG.md#088)

Merge pull request opentensor#2999 from opentensor/feat/roman/add-new…

ee0f422

…-crv3-logic Add new CRv4 logic

Merge branch 'staging' into fix/thewhaleking/fix-test-breakages

35a2779

Merge pull request opentensor#3011 from opentensor/fix/thewhaleking/f…

38e0943

…ix-test-breakages UV Fix

Update changelog + version

437a9b8

Merge pull request opentensor#3012 from opentensor/changelog/9.9.0

a605448

Update changelog + version

Major version locks drand

6843a1f

Merge pull request opentensor#3014 from opentensor/fix/thewhaleking/d…

245c64c

…rand-major-version Major version locks drand

Merge pull request opentensor#3013 from opentensor/release/9.9.0

1dc8d82

Release/9.9.0

fix: reflect correct return types for get_delegated

ac81421

fix: it is actually delegated info not delegate info

ad9aa79

Added fee calculation and fixed tests for burned register.

3edcbb4

Added fee calculation for unstaking. Added TODOs with questions.

46d7847

Added fee calculation for sync unstaking aswell

a7b76b5

Ruff

3991115

Fix unit tests

d610bf5

thewhaleking and others added 20 commits October 8, 2025 22:38

Update type hint/docstring for ws_shutdown_timer

d65ad92

replace error

4d56e45

Merge pull request opentensor#3092 from opentensor/fix/roman/error

7e0deb8

replace error

Update bittensor/core/async_subtensor.py

d201019

Merge pull request opentensor#3090 from opentensor/chore/thewhaleking…

5f5eaa2

…/update-type-hints-ws-shutdown-timer Update type hint/docstring for ws_shutdown_timer

commenting on the test until the new governance come

c495cfe

Merge pull request opentensor#3101 from opentensor/fix/roman/sub-gove…

efbb483

…rnance-deadcode Commenting on the test until the new governance come

bumping scalecodec to 1.2.12

43be0fb

Merge pull request opentensor#3104 from opentensor/fix/roman/scalecodec

4ab92e2

Bumping scalecodec to 1.2.12

bumping version + changelog

f9f7350

Merge pull request opentensor#3105 from opentensor/changelog/9.12.1

f8dd7f8

Bumping version 9.12.1 + changelog

Merge pull request opentensor#3106 from opentensor/release/v9.12.1

c0dd7d3

Release/v9.12.1

improve workflow

e6e3253

Set Docker image tag based on label or branch

fa3b069

-R

2997ed9

main for master PR if not labels

f001f95

no needs for pull-docker-image

950ad66

Merge pull request opentensor#3187 from opentensor/feat/roman/workflo…

6264162

…w-e2e-tests Improve e2e tests workflow

fix: improve code quality and error handling

396000f

basfroman requested changes Dec 7, 2025

View reviewed changes

basfroman added the SDKv10 Use this label for issues and feature requests relevant to Bittensor SDK v10. label Dec 7, 2025

insert __all__

6b5b914

basfroman requested changes Dec 7, 2025

View reviewed changes

wnqqnw19 added 2 commits December 8, 2025 06:31

chore: remove comments in errors.py

4c0a1d1

fix: resolve linter errors and fix exception initialization

3ff491c

wnqqnw19 requested a review from basfroman December 8, 2025 14:42

basfroman approved these changes Dec 8, 2025

View reviewed changes

basfroman changed the base branch from master to SDKv10 December 8, 2025 20:01

basfroman closed this Dec 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: improve code quality and error handling #3193

fix: improve code quality and error handling #3193

Uh oh!

wnqqnw19 commented Dec 5, 2025

Uh oh!

basfroman left a comment

Uh oh!

basfroman Dec 7, 2025 •

edited

Loading

Uh oh!

wnqqnw19 Dec 7, 2025

Uh oh!

basfroman Dec 7, 2025

Uh oh!

wnqqnw19 Dec 7, 2025

Uh oh!

basfroman Dec 7, 2025 •

edited

Loading

Uh oh!

wnqqnw19 Dec 8, 2025 •

edited

Loading

Uh oh!

basfroman Dec 8, 2025

Uh oh!

wnqqnw19 Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		# Re-export exceptions from async_substrate_interface for convenience
		# These are already imported above, no need for redundant aliases

fix: improve code quality and error handling #3193

fix: improve code quality and error handling #3193

Uh oh!

Conversation

wnqqnw19 commented Dec 5, 2025

Uh oh!

basfroman left a comment

Choose a reason for hiding this comment

Uh oh!

basfroman Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wnqqnw19 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

basfroman Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

wnqqnw19 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

basfroman Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wnqqnw19 Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

basfroman Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

wnqqnw19 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

basfroman Dec 7, 2025 •

edited

Loading

basfroman Dec 7, 2025 •

edited

Loading

wnqqnw19 Dec 8, 2025 •

edited

Loading