-
Notifications
You must be signed in to change notification settings - Fork 39
Feat/crowdloans #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/crowdloans #657
Conversation
Failing for |
#658 will fix senate tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall solid, but there's some required changes.
The JSON output stuff isn't required (except remove the unused --json-output
args in the commands if you aren't implementing them), and can be added later (like when #649 is complete).
if estimated_calls > 1: | ||
console.print( | ||
f"\n[yellow]Note:[/yellow] Due to the [cyan]Refund Contributors Limit[/cyan] of {refund_limit:,} contributors per call,\n" | ||
f" you may need to execute this command [yellow]{estimated_calls} times[/yellow] to refund all contributors.\n" | ||
f" Each call will refund up to {refund_limit:,} contributors until all are processed.\n" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if this could just loop so they needn't manually run the command multiple times.
Crowdloans
1.
btcli crowd list
Important
Displays a list of all crowdloans with additional information.
All loans are shown except ones which are dissolved.
2.
btcli crowd info
Important
Displays detailed information about a specific crowdloan campaign
Information about the target call and parameters is also shown
3.
btcli crowd contribute
Important
Allows users to contribute to an existing crowdloan which is not finalized yet
Displays funding targets and other information as well
4.
btcli crowd withdraw
Important
Allows users to withdraw their funds from a crowd loan
Users can only withdraw their full amount; while creators can withdraw the amount except the deposit
5.
btcli crowd create
Important
Enables creation of new crowd funding campaigns
Campaigns can be of two types; either subnet leasing, or a funding campaign after which the assets will be transferred to an address
6.
btcli crowd finalize
Important
Allows creators to finalize an existing campaign
If target was general fundraising, amount will be transferred to the target address.
If the target was subnet lease, the chain will attempt to register the subnet and disburse the remaining amount to holders.
7.
btcli crowd refund
Important
Allows anyone to refund the contribution amount to all holders
This can only be called if the campaign has not finalized yet
Note
This refunds all amount to participants except the deposit set by the creator.
To fetch the deposit, creators can call
btcli crowd dissolve
8.
btcli crowd dissolve
Important
Once all the holders have had their contributions refunded, the creator can use this call to get back the deposit amount.
This can only be called if the campaign has not finalized AND
btcli crowd refund
is already called.