Fix hotkeypub #161
Merged
Fix hotkeypub #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
run-bittensor-cli-tests
basfroman
previously approved these changes
Aug 6, 2025
thewhaleking
dismissed
basfroman’s stale review
The merge-base changed after approval.
basfroman
previously approved these changes
Aug 6, 2025
thewhaleking
dismissed
basfroman’s stale review
The merge-base changed after approval.
basfroman
previously approved these changes
Aug 6, 2025
thewhaleking
dismissed
basfroman’s stale review
The merge-base changed after approval.
basfroman
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses the correct path.
The issue with
hotkeypubin 3.1.0 is that it mirrors the coldkeypub in that it creates a single file in the root directory of the wallet (e.g.~/.bittensor/wallets/hotkeypub.txt).While this makes sense for the coldkeypub (because there is one coldkey per wallet), this does not work for hotkeys, for which there are multiple per wallet.
Thus the hotkeypub should mirror the hotkey, just as the coldkeypub mirrors the coldkey, instead creating as many hotkeypub files for a given wallet as exist hotkeys.
Even the initial requirement in Discord speaks to this use case.