fix: resolve clippy warnings, broken doctest, and add unit tests#180
fix: resolve clippy warnings, broken doctest, and add unit tests#180Nicknamess96 wants to merge 1 commit intoopentensor:stagingfrom
Conversation
basfroman
left a comment
There was a problem hiding this comment.
pls resolve the conflicts after rebasing to staging
- Fix 5 mismatched_lifetime_syntaxes warnings in PyO3 bindings - Fix broken doctest in Wallet::create by converting Python-style docstring to idiomatic Rust doc comment format - Apply cargo fmt to resolve pre-existing formatting inconsistencies - Add 66 unit tests across config, keypair, keyfile, wallet, and utils modules (from 1 to 67 total tests) - All tests pass: cargo test --lib (67/67), cargo test --doc (0 failures)
cbebf94 to
6b1ea3d
Compare
|
Rebased onto staging and resolved conflicts — ready for re-review. |
|
Hey @basfroman — just a heads-up on the The This appears to have been introduced when the workflow was simplified in #177 (the old The newer CI runs after my rebase are also pending your approval ( |
|
Just to confirm — I checked the latest This PR actually fixes the clippy and doctest issues — the only remaining failure ( Happy to help with a fix for the CI workflow too if that would be useful! |
|
Hey @basfroman — rebased onto staging and all conflicts are resolved. The cargo test failure is a pre-existing pyo3 linker issue that also fails on staging itself. Ready for re-review whenever you get a chance. |
Summary
Fix compiler warnings, a broken doctest, and add comprehensive unit tests to the bittensor-wallet Rust library.
Changes
mismatched_lifetime_syntaxeswarnings in PyO3 binding functions by adding explicit'_lifetime annotations toCow<[u8]>return typesWallet::createthat causedcargo test --docto fail by converting Python-style docstring to idiomatic Rust/// # Argumentsformatcargo fmtto resolve pre-existing formatting inconsistencies inpython_bindings.rsTesting
cargo test --libpasses (67/67 tests)cargo test --docpasses (0 failures, previously 1 failure)cargo fmt --checkcleancargo buildproduces 0 lifetime warnings (previously 5)