Skip to content

Fix KeyPair.regenerate_* methods using seed#96

Merged
basfroman merged 6 commits intomainfrom
fix/roman/fix-regenerate-methods
Feb 13, 2025
Merged

Fix KeyPair.regenerate_* methods using seed#96
basfroman merged 6 commits intomainfrom
fix/roman/fix-regenerate-methods

Conversation

@basfroman
Copy link
Collaborator

@basfroman basfroman commented Feb 13, 2025

  • fixed KeyPair.regenerate_* methods
  • remove KeyPair fields with sensitive data (seed_hex, private_key, and mnemonic)

@basfroman basfroman requested a review from a team February 13, 2025 04:37
@basfroman basfroman self-assigned this Feb 13, 2025
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotkey should be no password

Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
camfairchild
camfairchild previously approved these changes Feb 13, 2025
@basfroman basfroman merged commit d21ff75 into main Feb 13, 2025
12 checks passed
@basfroman basfroman deleted the fix/roman/fix-regenerate-methods branch February 13, 2025 06:12
@ibraheem-abe ibraheem-abe mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants