Skip to content

hyperparameter refactor #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
l0r1s merged 10 commits into from
Sep 16, 2025
Merged

hyperparameter refactor #2048

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
383956c
lower hyperparameter rate limit to 2 tempos
sam0x17 Sep 11, 2025
8d1dc41
allow setting storage based on tempos
sam0x17 Sep 11, 2025
7d24770
make hyperparameter specific
sam0x17 Sep 11, 2025
0d2dee4
Rename tempos -> epochs
ales-otf Sep 12, 2025
b0f963b
Refactor TransactionType
ales-otf Sep 12, 2025
cdfccff
Test hyperparams updates rate limited independently
ales-otf Sep 12, 2025
e700fed
Reformat
ales-otf Sep 12, 2025
c368318
Update localnet patch
ales-otf Sep 12, 2025
e3e377f
Remove owner hparam to epochs migration
ales-otf Sep 15, 2025
25e7402
Resolve git conflicts
ales-otf Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions evm-tests/test/neuron.precompile.reveal-weights.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ describe("Test neuron precompile reveal weights", () => {
const sudoFreezeTx = api.tx.Sudo.sudo({ call: setFreezeWindow.decodedCall })
await waitForTransactionWithRetry(api, sudoFreezeTx, alice)

// Set OwnerHyperparamRateLimit to 0
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ limit: BigInt(0) })
// Set OwnerHyperparamRateLimit to 0 (disable RL)
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ epochs: 0 })
const sudoOwnerRateTx = api.tx.Sudo.sudo({ call: setOwnerRateLimit.decodedCall })
await waitForTransactionWithRetry(api, sudoOwnerRateTx, alice)
}
Expand Down
4 changes: 2 additions & 2 deletions evm-tests/test/neuron.precompile.set-weights.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ describe("Test neuron precompile contract, set weights function", () => {
const sudoFreezeTx = api.tx.Sudo.sudo({ call: setFreezeWindow.decodedCall })
await waitForTransactionWithRetry(api, sudoFreezeTx, alice)

// Set OwnerHyperparamRateLimit to 0
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ limit: BigInt(0) })
// Set OwnerHyperparamRateLimit to 0 (disable RL)
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ epochs: 0 })
const sudoOwnerRateTx = api.tx.Sudo.sudo({ call: setOwnerRateLimit.decodedCall })
await waitForTransactionWithRetry(api, sudoOwnerRateTx, alice)
}
Expand Down
4 changes: 2 additions & 2 deletions evm-tests/test/staking.precompile.reward.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ describe("Test neuron precompile reward", () => {
const sudoFreezeTx = api.tx.Sudo.sudo({ call: setFreezeWindow.decodedCall })
await waitForTransactionWithRetry(api, sudoFreezeTx, alice)

// Set OwnerHyperparamRateLimit to 0
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ limit: BigInt(0) })
// Set OwnerHyperparamRateLimit to 0 (disable RL)
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ epochs: 0 })
const sudoOwnerRateTx = api.tx.Sudo.sudo({ call: setOwnerRateLimit.decodedCall })
await waitForTransactionWithRetry(api, sudoOwnerRateTx, alice)
}
Expand Down
4 changes: 2 additions & 2 deletions evm-tests/test/subnet.precompile.hyperparameter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ describe("Test the Subnet precompile contract", () => {
const sudoFreezeTx = api.tx.Sudo.sudo({ call: setFreezeWindow.decodedCall })
await waitForTransactionWithRetry(api, sudoFreezeTx, alice)

// Set OwnerHyperparamRateLimit to 0
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ limit: BigInt(0) })
// Set OwnerHyperparamRateLimit to 0 (disable RL)
const setOwnerRateLimit = api.tx.AdminUtils.sudo_set_owner_hparam_rate_limit({ epochs: 0 })
const sudoOwnerRateTx = api.tx.Sudo.sudo({ call: setOwnerRateLimit.decodedCall })
await waitForTransactionWithRetry(api, sudoOwnerRateTx, alice)
}
Expand Down
2 changes: 1 addition & 1 deletion pallets/admin-utils/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ mod benchmarks {
#[benchmark]
fn sudo_set_owner_hparam_rate_limit() {
#[extrinsic_call]
_(RawOrigin::Root, 10u64/*limit*/)/*sudo_set_owner_hparam_rate_limit*/;
_(RawOrigin::Root, 2u16/*epochs*/)/*sudo_set_owner_hparam_rate_limit*/;
}

#[benchmark]
Expand Down
Loading
Loading