Skip to content

Fix subnet alpha out burn discrepancy #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dairus01 wants to merge 13 commits into
base: devnet-ready
Choose a base branch
from
+9 −7
Open

Fix subnet alpha out burn discrepancy #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6e3d24c
Merge pull request #2308 from opentensor/testnet
sam0x17 Dec 19, 2025
0c94986
Fix SubnetAlphaOut burn discrepancy
Dairus01 Dec 31, 2025
b912711
Fix missing closing brace in CommitmentsInterface
Dairus01 Jan 6, 2026
ce5a716
Fix missing closing brace in CommitmentsInterface
Dairus01 Jan 6, 2026
07c5d3c
Fix missing newline at end of recycle_alpha.rs
Dairus01 Jan 6, 2026
ea7a288
Update test to assert SubnetAlphaOut is not reduced
Dairus01 Jan 6, 2026
67ace5d
Delete pallets/subtensor/src/tests/regression_issue_2274.rs
Dairus01 Jan 6, 2026
cbd1a9e
Modify burn_subnet_alpha to be a no-op
Dairus01 Jan 6, 2026
0ae1709
Remove regression_issue_2274 module from tests
Dairus01 Jan 6, 2026
dd96f6b
Reorder weights module import in tests
Dairus01 Jan 6, 2026
5400806
Add newline at end of recycle_alpha.rs
Dairus01 Jan 6, 2026
2b2a0ce
Fix missing closing brace in CommitmentsInterface
Dairus01 Jan 6, 2026
2530581
Update assertions to check for no decrease in subnet alpha
Dairus01 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pallets/subtensor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2633,14 +2633,16 @@ impl<T: Config + pallet_balances::Config<Balance = u64>>
Error::<T>::HotKeyAccountNotExists
);

let actual_alpha = Self::decrease_stake_for_hotkey_and_coldkey_on_subnet(
hotkey, coldkey, netuid, alpha,
);

// Decrese alpha out counter
SubnetAlphaOut::<T>::mutate(netuid, |total| {
*total = total.saturating_sub(alpha);
*total = total.saturating_sub(actual_alpha);
});

Ok(Self::decrease_stake_for_hotkey_and_coldkey_on_subnet(
hotkey, coldkey, netuid, alpha,
))
Ok(actual_alpha)
}
}

Expand Down
6 changes: 3 additions & 3 deletions pallets/subtensor/src/tests/recycle_alpha.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ fn test_burn_success() {
));

assert!(TotalHotkeyAlpha::<Test>::get(hotkey, netuid) < initial_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha); // Expect NO decrease
assert!(
SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hotkey, &coldkey, netuid)
< stake.into()
Expand Down Expand Up @@ -307,7 +307,7 @@ fn test_burn_staker_is_nominator() {
));

assert!(TotalHotkeyAlpha::<Test>::get(hotkey, netuid) < initial_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha); // Expect NO decrease
assert!(
SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(
&hotkey,
Expand Down Expand Up @@ -376,7 +376,7 @@ fn test_burn_two_stakers() {
));

assert!(TotalHotkeyAlpha::<Test>::get(hotkey, netuid) < initial_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha);
assert!(SubnetAlphaOut::<Test>::get(netuid) == initial_net_alpha); // Expect NO decrease
assert!(
SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hotkey, &coldkey, netuid)
< stake.into()
Expand Down