Skip to content

Fix/Don't Enable User Liquidity on Subnet Reg #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam0x17 merged 5 commits into from
Jan 8, 2026
+4 −5
Merged

Fix/Don't Enable User Liquidity on Subnet Reg #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fce6cb3
do not enable user liquidity on registration
JohnReedV Jan 5, 2026
6c566aa
clippy
JohnReedV Jan 5, 2026
ad982d6
bump spec
JohnReedV Jan 5, 2026
68c3b67
fix test
JohnReedV Jan 5, 2026
0d92984
auto-update benchmark weights
github-actions[bot] Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pallets/subtensor/src/macros/dispatches.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,7 +1231,7 @@ mod dispatches {
#[pallet::call_index(59)]
#[pallet::weight((Weight::from_parts(235_400_000, 0)
.saturating_add(T::DbWeight::get().reads(36_u64))
.saturating_add(T::DbWeight::get().writes(53_u64)), DispatchClass::Normal, Pays::Yes))]
.saturating_add(T::DbWeight::get().writes(52_u64)), DispatchClass::Normal, Pays::Yes))]
pub fn register_network(origin: OriginFor<T>, hotkey: T::AccountId) -> DispatchResult {
Self::do_register_network(origin, &hotkey, 1, None)
}
Expand Down Expand Up @@ -1519,7 +1519,7 @@ mod dispatches {
#[pallet::call_index(79)]
#[pallet::weight((Weight::from_parts(234_200_000, 0)
.saturating_add(T::DbWeight::get().reads(35_u64))
.saturating_add(T::DbWeight::get().writes(52_u64)), DispatchClass::Normal, Pays::Yes))]
.saturating_add(T::DbWeight::get().writes(51_u64)), DispatchClass::Normal, Pays::Yes))]
pub fn register_network_with_identity(
origin: OriginFor<T>,
hotkey: T::AccountId,
Expand Down
2 changes: 0 additions & 2 deletions pallets/subtensor/src/subnets/subnet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use super::*;
use sp_core::Get;
use subtensor_runtime_common::{NetUid, TaoCurrency};
use subtensor_swap_interface::SwapHandler;
impl<T: Config> Pallet<T> {
/// Returns true if the subnetwork exists.
///
Expand Down Expand Up @@ -247,7 +246,6 @@ impl<T: Config> Pallet<T> {
Self::deposit_event(Event::SubnetIdentitySet(netuid_to_register));
}

T::SwapInterface::toggle_user_liquidity(netuid_to_register, true);
// --- 18. Emit the NetworkAdded event.
log::info!("NetworkAdded( netuid:{netuid_to_register:?}, mechanism:{mechid:?} )");
Self::deposit_event(Event::NetworkAdded(netuid_to_register, mechid));
Expand Down
1 change: 1 addition & 0 deletions pallets/subtensor/src/tests/networks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,6 +1820,7 @@ fn massive_dissolve_refund_and_reregistration_flow_is_lossless_and_cleans_state(
let ct = pallet_subtensor_swap::CurrentTick::<Test>::get(net);
let lo = ct.saturating_sub(band);
let hi = ct.saturating_add(band);
pallet_subtensor_swap::EnabledUserLiquidity::<Test>::insert(net, true);
assert_ok!(pallet_subtensor_swap::Pallet::<Test>::add_liquidity(
RuntimeOrigin::signed(cold),
hot,
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// `spec_version`, and `authoring_version` are the same between Wasm and native.
// This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
// the compatible custom types.
spec_version: 365,
spec_version: 366,
impl_version: 1,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down