Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
9fea662 to
1a202a4
Compare
|
Hi @OmegaRelay Thanks for contribution! What's the specific use case for ML-EID? Why not returning the OMR address which is externally routable or all the addresses? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
===========================================
- Coverage 55.77% 43.38% -12.39%
===========================================
Files 87 110 +23
Lines 6890 13405 +6515
Branches 0 956 +956
===========================================
+ Hits 3843 5816 +1973
- Misses 3047 7279 +4232
- Partials 0 310 +310 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @wgtdkp, I only added support for MLEID as that's what we need in our application for network service discovery. I would be happy to expand it to support all ip addresses if that's preferred? |
1a202a4 to
6fac496
Compare
…r to respond with all ip addresses
6fac496 to
0b274df
Compare
|
Hi @wgtdkp I have now extended the functionality to support more ip address types. A get request on the And I've added |
We'd like to add a small PR to add functionality to retrieve the current mleid IP address of the border router over rest API. This PR adds a new endpoint
/node/ip-address/mleidwhich only accepts GET requests and responds with the mleid ip address string.