[wip]fix: replace chart components with huicharts equivalents and update ependencies#94
[wip]fix: replace chart components with huicharts equivalents and update ependencies#94
Conversation
WalkthroughConsolidated multiple separate chart package dependencies into a single Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/materials/vue-opentiny-vue/src/extend-renderer.ts (1)
18-29: Consider adding legacyTinyChart*aliases for migration safety.The whitelist includes legacy
TinyChart*names (lines 74-79 of white-list.ts), but onlyTinyHuicharts*are registered in the Mapper. If external schemas or persisted data use the legacy names, rendering will fail silently. While no internal schemas currently reference them, adding temporary aliases provides a safer migration path:Optional alias block for backward compatibility
Mapper.TinyHuichartsLine = TinyHuichartsLine; Mapper.TinyHuichartsHistogram = TinyHuichartsHistogram; Mapper.TinyHuichartsBar = TinyHuichartsBar; Mapper.TinyHuichartsRadar = TinyHuichartsRadar; Mapper.TinyHuichartsRing = TinyHuichartsRing; Mapper.TinyHuichartsPie = TinyHuichartsPie; Mapper.TinyHuichartsFunnel = TinyHuichartsFunnel; Mapper.TinyHuichartsScatter = TinyHuichartsScatter; Mapper.TinyHuichartsWaterfall = TinyHuichartsWaterfall; Mapper.TinyHuichartsGauge = TinyHuichartsGauge; Mapper.TinyHuichartsGraph = TinyHuichartsGraph; Mapper.TinyHuichartsProcess = TinyHuichartsProcess; + Mapper.TinyChartLine = TinyHuichartsLine; + Mapper.TinyChartHistogram = TinyHuichartsHistogram; + Mapper.TinyChartBar = TinyHuichartsBar; + Mapper.TinyChartRadar = TinyHuichartsRadar; + Mapper.TinyChartRing = TinyHuichartsRing; + Mapper.TinyChartPie = TinyHuichartsPie;Alternatively, if legacy names are no longer needed, remove them from the whitelist and update any documentation about the migration.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/materials/vue-opentiny-vue/src/extend-renderer.ts` around lines 18 - 29, The Mapper currently registers only TinyHuicharts* components (e.g., Mapper.TinyHuichartsLine, TinyHuichartsPie, TinyHuichartsBar, TinyHuichartsRadar, TinyHuichartsRing, TinyHuichartsFunnel, TinyHuichartsScatter, TinyHuichartsWaterfall, TinyHuichartsGauge, TinyHuichartsGraph, TinyHuichartsProcess) but the whitelist still contains legacy TinyChart* names; add temporary alias entries mapping the legacy symbols to the new ones (for example assign Mapper.TinyChartLine = Mapper.TinyHuichartsLine, Mapper.TinyChartPie = Mapper.TinyHuichartsPie, etc.) so external schemas or persisted data using TinyChart* continue to render, or alternatively remove the legacy names from the whitelist and update docs if you intend to drop them entirely.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/materials/vue-opentiny-vue/src/extend-renderer.ts`:
- Around line 18-29: The Mapper currently registers only TinyHuicharts*
components (e.g., Mapper.TinyHuichartsLine, TinyHuichartsPie, TinyHuichartsBar,
TinyHuichartsRadar, TinyHuichartsRing, TinyHuichartsFunnel,
TinyHuichartsScatter, TinyHuichartsWaterfall, TinyHuichartsGauge,
TinyHuichartsGraph, TinyHuichartsProcess) but the whitelist still contains
legacy TinyChart* names; add temporary alias entries mapping the legacy symbols
to the new ones (for example assign Mapper.TinyChartLine =
Mapper.TinyHuichartsLine, Mapper.TinyChartPie = Mapper.TinyHuichartsPie, etc.)
so external schemas or persisted data using TinyChart* continue to render, or
alternatively remove the legacy names from the whitelist and update docs if you
intend to drop them entirely.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2c92e076-f801-4cf5-98c1-0922e7277cd2
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
packages/frameworks/vue/package.jsonpackages/materials/vue-opentiny-vue/package.jsonpackages/materials/vue-opentiny-vue/src/extend-renderer.tspackages/materials/vue-opentiny-vue/src/render-config/chart.jsonpackages/materials/vue-opentiny-vue/src/render-config/white-list.ts
Summary by CodeRabbit
New Features
Chores