Skip to content

Conversation

@vaebe
Copy link
Contributor

@vaebe vaebe commented Jan 19, 2026

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

bbbb121e-476d-46cd-b72d-5edb0e7a5e20

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor
    • Optimized Vue component imports across multiple views to improve code maintainability and align with script setup best practices.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Jan 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

This PR removes explicit imports of Vue 3 compiler macros (defineProps and defineExpose) from <script setup> blocks across 17 component files. The components continue to use these macros, relying on their global availability within the script setup context rather than explicit imports.

Changes

Cohort / File(s) Summary
Breadcrumb & List Components
template/tinyvue/src/components/breadcrumb/index.vue, template/tinyvue/src/views/list/card-list/components/image.vue
Removed defineProps import while maintaining its usage
Form Components
template/tinyvue/src/views/form/base/components/detail-info.vue, template/tinyvue/src/views/form/step/components/collapse-form.vue, template/tinyvue/src/views/form/step/components/summation-form.vue, template/tinyvue/src/views/form/step/components/target-form.vue
Removed defineExpose import while maintaining its usage
User Info Filter Components
template/tinyvue/src/views/user/info/components/info-filter.vue, template/tinyvue/src/views/user/info/components/info-filterEndTime.vue, template/tinyvue/src/views/user/info/components/info-filterStartTime.vue, template/tinyvue/src/views/user/info/components/info-filterStatue.vue, template/tinyvue/src/views/user/info/components/info-filterStatus.vue, template/tinyvue/src/views/user/info/components/info-filterType.vue
Removed defineExpose and/or defineProps imports while maintaining their usage
User Info Other Components
template/tinyvue/src/views/user/info/components/info-chart.vue, template/tinyvue/src/views/user/info/components/info-table.vue
Removed defineProps import while maintaining its usage
User Management & Settings
template/tinyvue/src/views/user/setting/components/set-from.vue, template/tinyvue/src/views/userManager/user-detail/index.vue, template/tinyvue/src/views/userManager/useradd/index.vue
Removed defineProps and/or defineExpose imports while maintaining their usage

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Imports take a hop away,
Macros global save the day,
Script setup knows them oh so well,
Cleaner code with less to tell!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: treating defineProps and defineExpose as compiler macros that no longer require explicit imports, which aligns with all file modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kagol kagol merged commit d57ccbd into opentiny:dev Jan 19, 2026
3 of 4 checks passed
@vaebe vaebe deleted the remove-redundant-template-files branch January 19, 2026 03:27
@kagol
Copy link
Member

kagol commented Jan 19, 2026

@all-contributors please add @vaebe for code.

@allcontributors
Copy link
Contributor

@kagol

I've put up a pull request to add @vaebe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants