Skip to content

feat(sender): replace wave image with IconRecordingWave icon#285

Merged
hexqi merged 1 commit intoopentiny:developfrom
SonyLeo:feat/replace-recording-icon
Jan 14, 2026
Merged

feat(sender): replace wave image with IconRecordingWave icon#285
hexqi merged 1 commit intoopentiny:developfrom
SonyLeo:feat/replace-recording-icon

Conversation

@SonyLeo
Copy link
Collaborator

@SonyLeo SonyLeo commented Jan 14, 2026

优化 sender 组件 录制中 图标效果

Summary by CodeRabbit

  • Style
    • Enhanced the voice recording indicator visual for improved user feedback during active recording sessions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Walkthrough

The ActionButtons component replaces a static voice recording wave image with a dedicated IconRecordingWave component from the icon library. CSS rules for the recording indicator sizing have been removed, delegating the rendering to the component itself.

Changes

Cohort / File(s) Summary
Voice Recording Indicator Component Update
packages/components/src/sender/components/ActionButtons.vue
Replaced static img element with IconRecordingWave component for voice recording indicator; added icon library import; removed associated CSS sizing rules (7 lines removed, 3 lines added)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A wave of change, so sleek and bright,
Static images now lose their light,
Icons dance where images stood,
Simpler code, refined and good!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change in the pull request - replacing a wave image (wave.webp) with the IconRecordingWave component in the sender's ActionButtons component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03aaa92 and a5ddee5.

⛔ Files ignored due to path filters (1)
  • packages/svgs/src/assets/recording-wave.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • packages/components/src/sender/components/ActionButtons.vue
🔇 Additional comments (2)
packages/components/src/sender/components/ActionButtons.vue (2)

5-5: LGTM!

The import follows the existing pattern for icons from @opentiny/tiny-robot-svgs.


224-225: Clean icon replacement with proper component integration.

The IconRecordingWave component is correctly imported from @opentiny/tiny-robot-svgs and generated from recording-wave.svg during the build process. The implementation maintains visual consistency with other action button icons using the action-buttons__icon class, and the v-else directive properly pairs with the conditional on line 223.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

✅ Preview build completed successfully!

Click the image above to preview.
Preview will be automatically removed when this PR is closed.

@github-actions
Copy link
Contributor

@hexqi hexqi merged commit b6700a6 into opentiny:develop Jan 14, 2026
4 checks passed
@github-actions
Copy link
Contributor

🧹 Preview Cleaned Up

The preview deployment has been removed.

@SonyLeo SonyLeo deleted the feat/replace-recording-icon branch January 15, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants