Skip to content

Conversation

@gausszhou
Copy link
Contributor

@gausszhou gausszhou commented Dec 18, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

图标相对文字有点偏下

image image image

Issue Number: N/A

What is the new behavior?

image image image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Improved horizontal alignment of status icons and text within modal dialogs for better visual consistency across alert and confirm modals.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Dec 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Updated modal dialog styling by applying flexbox layout properties to the status wrapper. Added display: flex and align-items: center to the modal status area, aligning the status icon and text horizontally within the modal header for both alert and confirm components.

Changes

Cohort / File(s) Summary
Modal Status Styling
packages/theme/src/modal/index.less
Added flexbox layout to modal status wrapper with display: flex and align-items: center for horizontal alignment of status icon and text

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single CSS property update with minimal scope
  • No logic changes or side effects to evaluate

Poem

🐰 A modal so neat, its status stands tall,
Flexbox aligned, centering all!
Icons and text in harmony dance,
No more misalignment's awkward prance.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main bugfix: fixing vertical centering of the title icon in modal alert and confirm dialogs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zzcr zzcr merged commit 2889bcb into opentiny:dev Dec 19, 2025
25 of 28 checks passed
KevinAndrewDong added a commit to KevinAndrewDong/tiny-vue that referenced this pull request Dec 23, 2025
…wdong/feat-select-docs

* 'dev' of https://github.com/opentiny/tiny-vue: (152 commits)
  feat: add triggering conditions (opentiny#3922)
  fix:修复初始化tab内容无法加载问题 (opentiny#3920)
  fix(modal): 修复 modal 组件在 alert, confirm 的弹窗场景下标题图标没有垂直局中的问题 (opentiny#3917)
  fix(dropdown): add aria information to the dropdown component (opentiny#3913)
  feat:下拉树支持懒加载 (opentiny#3915)
  docs: update introduce doc (opentiny#3914)
  feat:select-wrapper多端示例以及文档 (opentiny#3882)
  feat:select-wrapper多端 (opentiny#3881)
  fix(transfer): fix it works when item data  receive empty object (opentiny#3912)
  feat(switch): add width property to support custom switch width (opentiny#3879)
  fix: optimize the training ground (opentiny#3911)
  fix(e2e): fix e2e error caused by select refactor (opentiny#3905)
  feat: automatically trigger updates to the docs document (opentiny#3906)
  feat: add auto-build-main-module-docs yml (opentiny#3910)
  fix(split): add saas style (opentiny#3908)
  fix(grid): fix visible columns change wloud delete insert row (opentiny#3897)
  chore: add svg icon-layout-vertical (opentiny#3904)
  fix(saas-icon): add lost icon (opentiny#3903)
  fix: 修复saas-common 构建报错 (opentiny#3901)
  fix(grid): add border-top when set border is true (opentiny#3896)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants