Improve resource disposal of GLWpfControl#141
Closed
4nonym0us wants to merge 1 commit intoopentk:masterfrom
Closed
Improve resource disposal of GLWpfControl#1414nonym0us wants to merge 1 commit intoopentk:masterfrom
GLWpfControl#1414nonym0us wants to merge 1 commit intoopentk:masterfrom
Conversation
…ntrol hasn't been disposed yet.
Member
|
Thanks for creating this PR, I've opened up #143 which fixes this issue and does some cleanup on the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GLWpfControl.OnUnloaded()was updated to only release resorces if the control hasn't been disposed yet.Behavior
Before
OnUnloadedcould be fired after the disposal of the control.After
Resources are being released in
OnUnloadedonly when the control is active (_isStartedis true, which is basically from the moment it was started to the moment it's disposed).