lint: reintroduce ST1005 static check#3634
Conversation
Signed-off-by: Larry Bordowitz <laurence.bordowitz@gmail.com>
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
|
AFAICT, there are different paths for an error to be handled:
IMO, the first part shouldn't be that concerning because if an error bubbles up outside of a diagnostic context, we use I would focus more on the diagnostic side of things, where we can create a custom error type and use that to carry information for raw error rendering and for diagnostic rendering. For example, we might work something in here. Maybe there is already something similar for diagnostics, so I would be curious to hear from the other maintainers that has more knowledge on this side |
This draft pull request for removing a linter static check exclusion is for demonstration purposes only.
For the sake of user friendliness, we capitalize some errors and add punctuation at the end as well. This chafes against ST1005, which is concerned with the composability of error messages. I will recommend a couple different paths:
I have my preference, but I'll keep it close to the vest for the sake of healthy conversation.