This repository was archived by the owner on May 23, 2023. It is now read-only.
Add StartSpanFollowsFromContext function#224
Open
jpiper wants to merge 1 commit intoopentracing:masterfrom
Open
Add StartSpanFollowsFromContext function#224jpiper wants to merge 1 commit intoopentracing:masterfrom
jpiper wants to merge 1 commit intoopentracing:masterfrom
Conversation
There are many situations where you might wish to start spans as a followsFrom (e.g. when interacting with a message bus). This adds convenience functions around this
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage ? 59.64%
=========================================
Files ? 14
Lines ? 840
Branches ? 0
=========================================
Hits ? 501
Misses ? 299
Partials ? 40
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on lots of tracing where data is exchanged via a message broker, so we're always wanting to start spans as followsFrom rather than ChildOf. As far as I can see, there isn't anything out of the box that deals with this so I've added the functions that would do it here, just in case you think this would be useful.