fix: #116 Add outputMetricUnits to config types and use in itinerary-…

[amenk]

…body

[amenk]

TODO:

1. Add to

packages/location-field/src/options.tsx:90

{humanizeDistanceString(stop.dist, config.outputMetricUnits,true)}

But we have to pass through the config somehow.

2. Also in the printable printable-itinerary still imperial units are used, but I couldn't figure out where this is rendered.

[amenk]

2. using react dev tools I confirmed that the config is correct in the print-component - I actually think this is related to my workflow (trip form: add callback for detecting when all submodes are disabled #773), because printable-itinerary depends on itinerary-body and probably is using the old version. So not a real issue.

[amenk]

[amenk]

Not sure if c389bed is the right approach (to pass the outputMetricUnits into the location field component) of if we should access some global configuration from there.

[miles-grant-ibigroup]

Sorry for the long delay on this, but have finally had the time to take a look at this. I don't mind this approach, however is it not possible to use react-intl to handle this?

[amenk]

Thanks, what do you mean exactly?

[miles-grant-ibigroup]

Is https://formatjs.io/docs/react-intl/api#formatnumber not appropriate here?

[amenk]

@miles-grant-ibigroup I don't know. As you can see from the PR, there is already a humanizeDistanceString function in the code base which can be used.

It's more about passing the setting, whether to use imperial or metric all the way down to the components.

[miles-grant-ibigroup]

Thanks for clarifying, I've discussed it with others and I think your approach is the best way to implement this feature. Once the PR is ready the approach has my approval!

[amenk]

@miles-grant-ibigroup cool :-) Actually I have technical problems to complete the PR ... still this yarn linking stuff :-(
In case you want to pick up...

There are really more countries (luckily IMO) using the metric system than the imperial one ;-)