feat(core-utils): restore walkSpeed param for walk-only trips#813
feat(core-utils): restore walkSpeed param for walk-only trips#813themapwizard wants to merge 1 commit intoopentripplanner:masterfrom
Conversation
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Looking at the failing snapshots, it looks like these 2 variables are being applied in many cases where they perhaps should not be. This PR would send a default 2 walkReluctance along in many cases where it perhaps should not be. If this is desired, then I'd consider this a change that might make more sense within the trimet-specific map form component.
f479aca to
4f53792
Compare
this should no longer be an issue, i've update the PR to only add back walkSpeed |
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
If you go ahead and update the snapshots then I think this is good to go!
updated |
|
It doesn't look like that quite worked! Did you try running |
I originally ran it with jest directly, i just re-ran with |
|
Sorry @themapwizard |
|
I was able to do it myself but I can't push to your branch so you'll have to do it yourself. Sorry for the runaround. |
|
Hi @lightsage88 Do you still need this PR? There are conflicts and failing tests. |
See PRJ77-715
This PR adds walkSpeed to core-utils\src\query-params.js and adds them to the default params in core-utils\src\query.js.
This is for trimet.org and will add back walkSpeed for walk only modes. We needed to add back walkSpeed because latest versions 12.0.2 do not contain walkSpeed and upgrading in trimet.org would render no settings in the walk only panel (see screenshots).
walk only:
