Add a lineGap configuration option to the Font object#681
Open
sammyfeng0530 wants to merge 3 commits intoopentypejs:masterfrom
Open
Add a lineGap configuration option to the Font object#681sammyfeng0530 wants to merge 3 commits intoopentypejs:masterfrom
sammyfeng0530 wants to merge 3 commits intoopentypejs:masterfrom
Conversation
|
Hmm, HHEA gap and OS2 gap can be different in fonts and there are a lot fonts out there where that is the case. I must admit I do not understand the issue, but this code enforces that both gap values are always the same: Here an example of a commercial font with different gap values. This is what |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add a 'lineGap' configuration option to the Font object.
Description
Add a 'lineGap' configuration option to the Font object, so that the generated font file when calling toArrayBuffer includes the 'lineGap' property.
Motivation and Context
I need the 'lineGap' property to calculate the automatic height of text. Currently, the generated font file does not include this property, which causes inaccuracies in my text's automatic height calculation.
How Has This Been Tested?
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).