Skip to content

Fixed gasp support bugs per #738 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Fixed gasp support bugs per #738 #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
235943a
Fixed gasp support bugs per #738
Balearica Jul 8, 2024
5e91e9c
Added test for gasp table writing
Balearica Jul 9, 2024
c436359
Minor update to test
Balearica Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/opentype.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,13 @@ function parseBuffer(buffer, opt={}) {
metaTableEntry = tableEntry;
break;
case 'gasp':
table = uncompressTable(data, tableEntry);
font.tables.gasp = gasp.parse(table.data, table.offset);
try {
table = uncompressTable(data, tableEntry);
font.tables.gasp = gasp.parse(table.data, table.offset);
} catch (e) {
console.warn('Failed to parse gasp table, skipping.');
console.warn(e);
}
break;
case 'SVG ':
table = uncompressTable(data, tableEntry);
Expand Down
6 changes: 3 additions & 3 deletions src/tables/gasp.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ function makeGaspTable(gasp) {
{name: 'numRanges', type: 'USHORT', value: gasp.numRanges},
]);

for (let i in gasp.numRanges) {
result.fields.push({name: 'rangeMaxPPEM', type: 'USHORT', value: gasp.numRanges[i].rangeMaxPPEM});
result.fields.push({name: 'rangeGaspBehavior', type: 'USHORT', value: gasp.numRanges[i].rangeGaspBehavior});
for (let i in gasp.gaspRanges) {
result.fields.push({name: 'rangeMaxPPEM', type: 'USHORT', value: gasp.gaspRanges[i].rangeMaxPPEM});
result.fields.push({name: 'rangeGaspBehavior', type: 'USHORT', value: gasp.gaspRanges[i].rangeGaspBehavior});
}

return result;
Expand Down
5 changes: 5 additions & 0 deletions test/tables/gasp.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,9 @@ describe('tables/gasp.mjs', function () {
assert.equal(font.tables.gasp.gaspRanges[1].rangeGaspBehavior, 0x0001 + 0x0002 + 0x0004 + 0x0008); // all flags set = 15
});

it('can write tables that are read as identical to the original', function() {
const font2 = parse(font.toArrayBuffer());
assert.deepStrictEqual(font.tables.gasp, font2.tables.gasp);
});

});
Loading