Add write support for GPOS type 2 lookups (kerning)#743
Open
Balearica wants to merge 4 commits intoopentypejs:masterfrom
Open
Add write support for GPOS type 2 lookups (kerning)#743Balearica wants to merge 4 commits intoopentypejs:masterfrom
Balearica wants to merge 4 commits intoopentypejs:masterfrom
Conversation
f8403d7 to
be6a82b
Compare
be6a82b to
88cfaa5
Compare
This was referenced Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds write support for GPOS type 2 lookups (kerning).
kerntable (so thekerningPairsproperty is populated), thekerningPairsproperty is converted into a GPOS table and written to the output.Motivation and Context
This feature has been requested by many users over the years. See #95 and #547, among others.
How Has This Been Tested?
gpostable.kerntable is properly converted into agpostable.Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).