Open
Conversation
Ship .d.ts type definitions inside the npm package so TypeScript users no longer need the separate @types/opentype.js package. Uses JSDoc annotations in source files with tsc --allowJs --declaration to generate .d.mts files at build time. Core public API types: Font, Glyph, Path, BoundingBox, parse() - PathCommand discriminated union (M/L/C/Q/Z) for type-safe command handling - FontOptions, GlyphRenderOptions, GlyphOptions typed interfaces - All Font/Glyph/Path/BoundingBox methods and properties typed Infrastructure: - tsconfig.json for declaration generation - "b:types" build script integrated into "build" - package.json "types" field and "exports" map for bundler resolution - Type verification test (test/types/test-types.ts) with "test:types" script - Rename tiny-inflate file to remove @ that breaks TS module resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #809. Ships
.d.tstype definitions inside the npm package so TypeScript users no longer need the separate@types/opentype.jspackage.Font,Glyph,Path,BoundingBox,parse()) and usestsc --allowJs --declaration --emitDeclarationOnlyto generate.d.mtsfiles at build timePathCommanddiscriminated union (M/L/C/Q/Z) for type-safe command handling, plus typedFontOptions,GlyphRenderOptions, andGlyphOptionsinterfaces"types"field and"exports"map topackage.jsonfor proper TypeScript/bundler resolutiontiny-inflate@1.0.3.esm.mjs→tiny-inflate-1.0.3.esm.mjs(the@broke TypeScript module resolution)test/types/test-types.ts) that exercises the full public API under--strictmodeTest plan
npm run buildsucceeds (UMD + ESM + types generation)npm run test:typespasses (strict-mode type verification test)npx mocha --recursive— all 328 tests passnpm run lintpasses🤖 Generated with Claude Code