Skip to content

Conversation

@gleon99
Copy link
Contributor

@gleon99 gleon99 commented Nov 20, 2025

Port #11000

What?

Added default gateway support to the routing table reachability check
https://redmine.mellanox.com/issues/4659780

Summary by CodeRabbit

  • New Features

    • Detect IPoIB (InfiniBand) network interfaces.
    • Option to control whether default-gateway routes are considered during route checks.
  • Improvements

    • Device addresses now indicate allowance of default-gateway routing for non-IPoIB paths.
    • Reachability checks respect link-layer specifics and honor the new default-gateway option.
  • Bug Fixes

    • Corrected route parsing and destination initialization to avoid incorrect handling and errors.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gleon99 gleon99 changed the title Added default gateway support to the routing table reachability chec Add default gateway support to reachability check - 1.20 Nov 20, 2025
@gleon99 gleon99 requested a review from brminich November 20, 2025 10:52
@gleon99 gleon99 force-pushed the add-default-gateway-support-1.20 branch from 83ce439 to 9130921 Compare November 20, 2025 13:52
@gleon99 gleon99 changed the title Add default gateway support to reachability check - 1.20 UCS/SYS: Add default gateway support to reachability check - 1.20 Nov 20, 2025
@brminich brminich merged commit a7403a1 into openucx:v1.20.x Nov 21, 2025
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants