UCP/EP: UCP_ERR_HANDLING_MODE_FAILOVER fallback implementation #11067
+104
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeny-leksikov
force-pushed
the
ucp_ep_err_mode_failover
branch
2 times, most recently
from
b3f8f19 to
cfe0cbe
Compare
evgeny-leksikov
changed the title
shasson5
reviewed
Jan 8, 2026
shasson5
previously approved these changes
Jan 13, 2026
- fallback to UCP_EP_INIT_ERR_MODE_PEER_FAILURE - refactoring of err_mode getters and comparatort
evgeny-leksikov
force-pushed
the
ucp_ep_err_mode_failover
branch
from
0655f1f to
46f0b4a
Compare
yosefe
reviewed
Jan 19, 2026
src/ucp/core/ucp_ep.c
Outdated
| *ep_init_flags_p = (sa_data->header & UCP_SA_DATA_FLAG_ERR_MODE_PEER) ? | ||
| UCP_EP_INIT_ERR_MODE_PEER_FAILURE : 0; | ||
| UCP_EP_INIT_ERR_MODE_PEER_FAILURE : | ||
| (sa_data->header & UCP_SA_DATA_FLAG_ERR_MODE_FAILOVER) ? |
Contributor
There was a problem hiding this comment.
does it break wire compatibility?
src/ucp/core/ucp_ep.c
Outdated
Comment on lines
1152
to
1153
| (ep_init_flags & (UCP_EP_INIT_ERR_MODE_PEER_FAILURE | | ||
| UCP_EP_INIT_ERR_MODE_FAILOVER)) && |
Contributor
There was a problem hiding this comment.
maybe define that when FAILOVER mode is enabled, both UCP_EP_INIT_ERR_MODE_FAILOVER and UCP_EP_INIT_ERR_MODE_PEER_FAILURE bits should be set?
src/ucp/core/ucp_ep.c
Outdated
| UCS_LOG_LEVEL_DIAG : | ||
| UCS_LOG_LEVEL_ERROR; | ||
| log_level = | ||
| (ucp_ep_config_err_mode_eq(ucp_ep, |
Contributor
There was a problem hiding this comment.
can we use ucp_ep_config_err_handling_enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
UCP_ERR_HANDLING_MODE_FAILOVERfallback implementation:UCP_EP_ERR_HANDLING_MODE_PEER_FAILURE, this means that behavior of error handling modes "failover" and "peer" are equal.The PR depends on API proposal in #11064
Why?