Skip to content

UCP/CORE: Add rc_gda transport to alias list of ib #11170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosefe merged 7 commits into from
Mar 4, 2026
Merged

UCP/CORE: Add rc_gda transport to alias list of ib #11170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef85c3e
UCP/CORE: Add `rc_gda` transport to aliases list of `ib` and `cuda`
guy-ealey-morag Feb 5, 2026
1f03ecd
Merge branch 'master' into rc-gda-aliases
guy-ealey-morag Feb 20, 2026
a2ea158
UCP/CORE: Remove rc_gda from cuda alias
guy-ealey-morag Feb 20, 2026
6bdf742
Merge branch 'master' into rc-gda-aliases
guy-ealey-morag Feb 27, 2026
2e67fc2
TEST/UCP: Fix test by adding md index to comparison
guy-ealey-morag Feb 27, 2026
4f078f1
UCT/GDAKI: Fix fd leaks to allow CI to pass
guy-ealey-morag Mar 4, 2026
bc172bf
UCT/GDAKI: Fix PR comment
guy-ealey-morag Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ucp/core/ucp_context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2001-2019. ALL RIGHTS RESERVED.
* Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2001-2026. ALL RIGHTS RESERVED.
* Copyright (C) ARM Ltd. 2016. ALL RIGHTS RESERVED.
* Copyright (C) Intel Corporation, 2023. ALL RIGHTS RESERVED.
*
Expand Down Expand Up @@ -715,7 +715,7 @@ static ucp_tl_alias_t ucp_tl_aliases[] = {
{ "shm", { "posix", "sysv", "xpmem", "knem", "cma", NULL } },
{ "ib", { "rc_verbs", "ud_verbs", "rc_mlx5", "ud_mlx5", "dc_mlx5",
"gga_mlx5", UCP_TL_AUX("ud_mlx5"), UCP_TL_AUX("ud_verbs"),
"srd", NULL } },
"srd", "rc_gda", NULL } },
{ "ud_v", { "ud_verbs", NULL } },
{ "ud_x", { "ud_mlx5", NULL } },
{ "ud", { "ud_mlx5", "ud_verbs", NULL } },
Expand All @@ -726,7 +726,7 @@ static ucp_tl_alias_t ucp_tl_aliases[] = {
{ "dc", { "dc_mlx5", UCP_TL_AUX("ud_mlx5"), NULL } },
{ "dc_x", { "dc_mlx5", UCP_TL_AUX("ud_mlx5"), NULL } },
{ "ugni", { "ugni_smsg", UCP_TL_AUX("ugni_udt"), "ugni_rdma", NULL } },
{ "cuda", { "cuda_copy", "cuda_ipc", "gdr_copy", NULL } },
{ "cuda", { "cuda_copy", "cuda_ipc", "gdr_copy", "rc_gda", NULL } },
Copy link
Contributor

@brminich brminich Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we also want it in cuda alias. E.g. if I want to use UCX_TLS=rc,cuda it will automatically enable rc_gda (which requires a lot of resources). Also not sure if we need it in rc alias.
@ofirfarjun7, @Artemy-Mellanox wdyt?

Copy link
Contributor

@ofirfarjun7 ofirfarjun7 Feb 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it in rc alias what am I'm missing?
We need to disable it if user disables ib/cuda. Do we have other conventional way to do it beside the aliases?
Regarding resources, with latest implementation it create additional transport for each NIC (NIC-GPU) transport , but just one not all combos (@Artemy-Mellanox please correct me if I'm wrong).

Copy link
Contributor

@yosefe yosefe Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should be only for IB

{ "rocm", { "rocm_copy", "rocm_ipc", "rocm_gdr", NULL } },
{ "ze", { "ze_copy", "ze_ipc", "ze_gdr", NULL } },
{ "gga", { "gga_mlx5", NULL } },
Expand Down
4 changes: 2 additions & 2 deletions src/ucp/core/ucp_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2001-2015. ALL RIGHTS RESERVED.
* Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2001-2026. ALL RIGHTS RESERVED.
* Copyright (C) ARM Ltd. 2016. ALL RIGHTS RESERVED.
* Copyright (C) Advanced Micro Devices, Inc. 2019. ALL RIGHTS RESERVED.
*
Expand Down Expand Up @@ -286,7 +286,7 @@ typedef struct ucp_tl_resource_desc {
*/
typedef struct ucp_tl_alias {
const char *alias; /* Alias name */
const char* tls[10]; /* Transports which are selected by the alias */
const char* tls[11]; /* Transports which are selected by the alias */
} ucp_tl_alias_t;


Expand Down
Loading