UCT/CUDA/CUDA_IPC: Fixed cuda_ipc_cache cleanup at process termination.#11275
Draft
rakhmets wants to merge 1 commit intoopenucx:masterfrom
Draft
UCT/CUDA/CUDA_IPC: Fixed cuda_ipc_cache cleanup at process termination.#11275rakhmets wants to merge 1 commit intoopenucx:masterfrom
rakhmets wants to merge 1 commit intoopenucx:masterfrom
Conversation
0266978 to
f8a1d9f
Compare
f8a1d9f to
3bf315c
Compare
Contributor
|
so atexit handler would run before cuda driver is deinitialized? |
Contributor
Author
In most cases - yes. There are still some corner cases. E.g. if the first call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixed cuda_ipc_cache cleanup at process termination to close opened CUDA IPC memory handles.
Why?
UCS_STATIC_CLEANUPruns in a destructor when the UCX library is unloaded. Unload order is undefined, so the CUDA Driver can already be deinitialized. Thenuct_cuda_ipc_destroy_cache->uct_cuda_ipc_cache_purge->uct_cuda_ipc_primary_ctx_retain_and_pushcallscuDevicePrimaryCtxGetState, which (as any other CUDA Driver API) returnsCUDA_ERROR_DEINITIALIZED.