TOOLS/PERF: Split .cu file to make build from 6min down to around 4min#11279
Open
tvegas1 wants to merge 2 commits intoopenucx:masterfrom
Open
TOOLS/PERF: Split .cu file to make build from 6min down to around 4min#11279tvegas1 wants to merge 2 commits intoopenucx:masterfrom
tvegas1 wants to merge 2 commits intoopenucx:masterfrom
Conversation
Contributor
Author
|
How should I make sure that everything still work, functionality and perf? |
Contributor
Author
|
We can also try to split this AI-based concept PR, in multiple PR, if deemed useful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Proposal to split .cu file code in separate files.
Why?
Parallelize nvcc invocations, reduces build time from 5 min 57 sec, down to 4 min 15 sec.
How?
Keep Host,
__global__, and__device__functions in the same file, dispatching only the Host code for a given template instantiation.