UCT/PLUGIN: add definition in uct_iface_attr_v2_t for uct_iface_query_v2#11316
UCT/PLUGIN: add definition in uct_iface_attr_v2_t for uct_iface_query_v2#11316fteng-NV wants to merge 6 commits intoopenucx:masterfrom
Conversation
fteng-NV
force-pushed
the
feature/uct-api-v2
branch
from
e768a2c to
a6b8374
Compare
src/uct/api/v2/uct_v2.h
Outdated
| * Caller allocates a buffer of @ref uct_iface_attr_v2_t::tx_token_length | ||
| * bytes and sets this pointer; callee fills the buffer with the token. | ||
| */ | ||
| void *tx_token; |
There was a problem hiding this comment.
Extra leading space — tx_token and rx_token are indented 5 spaces, but all other struct members use 4.
🤖 Generated by Claude
src/uct/api/v2/uct_v2.h
Outdated
|
|
||
| /** Enables @ref uct_iface_attr_v2_t::tx_token_length (output). */ | ||
| UCT_IFACE_ATTR_FIELD_TX_TOKEN_LENGTH = UCS_BIT(1), | ||
|
|
There was a problem hiding this comment.
Blank line has trailing whitespace. Same issue on lines 1074, 1100, 1106, 1112, 1120 — will likely fail style/CI checks.
🤖 Generated by Claude
src/uct/api/v2/uct_v2.h
Outdated
| * When set, @ref uct_iface_attr_v2_t::tx_token is input (from sender), | ||
| * and @ref uct_iface_attr_v2_t::rx_token is output (derived by receiver). | ||
| */ | ||
| UCT_IFACE_ATTR_FIELD_RX_TOKEN = UCS_BIT(3) |
There was a problem hiding this comment.
Name is misleading — this single flag enables both tx_token (input) and rx_token (output). Consider UCT_IFACE_ATTR_FIELD_TOKEN_DERIVATION, or split into two separate bits.
🤖 Generated by Claude
There was a problem hiding this comment.
changed into two flags UCT_IFACE_ATTR_FIELD_TX_TOKEN and UCT_IFACE_ATTR_FIELD_RX_TOKEN and updated related code comments in 47c652c
src/uct/api/v2/uct_v2.h
Outdated
| * the TX token received from the sender. | ||
| * @ref UCT_IFACE_ATTR_FIELD_RX_TOKEN must be set together. | ||
| */ | ||
| const void *tx_token; |
There was a problem hiding this comment.
Could you please check the CI output and fix the formatting?
| /** | ||
| * Plugin-contributed capability flags (bitmask of UCT_IFACE_FLAG_*). | ||
| * Valid when @ref UCT_IFACE_ATTR_FIELD_FLAGS is set. | ||
| */ | ||
| uint64_t flags; |
There was a problem hiding this comment.
Why "Plugin-contributed"? maybe return all supported capabilities?
src/uct/api/v2/uct_v2.h
Outdated
| /* Reserved for future use */ | ||
| UCT_IFACE_ATTR_FIELD_RESERVED = 0 | ||
| /** Enables @ref uct_iface_attr_v2_t::flags (output). | ||
| * Returns plugin-contributed capability flags. |
4 participants
What?
add definition in uct_iface_attr_v2_t for uct_iface_query_v2.
Why?
The definition is used for following interface implementation. This PR is seperated from PR #11277