TOOLS/PERF/ZE: fix allocator thread safety and device routing#11320
Open
yafshar wants to merge 1 commit intoopenucx:masterfrom
Open
TOOLS/PERF/ZE: fix allocator thread safety and device routing#11320yafshar wants to merge 1 commit intoopenucx:masterfrom
yafshar wants to merge 1 commit intoopenucx:masterfrom
Conversation
- Replace global gpu_cmdlists with per-thread __thread command lists to eliminate data races in multi-threaded perf scenarios - Replace global gpu_index with per-thread tls_gpu_index to enable correct device routing based on each thread’s selected device - Use pthread_once for thread-safe one-time allocator initialization - Add NULL command list checks before allocation and memcpy/memset operations - Fix DEVICE and MANAGED allocations to use selected device index instead of hardcoded device 0 - Replace hardcoded gpu_page_size with dynamic ucs_get_page_size() - Add explicit error handling for invalid memory types instead of silently treating them as MANAGED - Add proper cleanup of per-thread command lists on module unload - Rename UCX_PERF_ZE_MAX_DEVICES to ZE_PERF_MAX_DEVICES for consistency
yafshar
force-pushed
the
topic/ze-perf-alloc-init-tls-fix
branch
from
bca1f08 to
77b74a4
Compare
yafshar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
and improve stability in multi-threaded perf scenarios.