Skip to content

Convolution default fixed, extensive tests #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blackencino merged 16 commits into from
Nov 5, 2025
Merged

Convolution default fixed, extensive tests #321

blackencino merged 16 commits into from
Nov 5, 2025

Conversation

@blackencino
Copy link
Contributor

@blackencino blackencino commented Nov 5, 2025

The default (gather/scatter) backend for convolution is fixed, with aggressive testing to confirm.

@blackencino
WIP on convolution ground truth tests
9b32fcf 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
WIP on convolution ground truth testing
50579b6 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
WIP Convolution Ground Truth - single and multiple impulses work
98aee19 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Merge branch 'main' into feature/conv_test_minimal_ground_truth
8bc65a6 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
WIP on (still quite broken) convolution ground truth
57934b2 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
WIP on ground truth kernel
d4ab569 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
WIP on convolution fixes
63cddc6 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Merge branch 'main' into feature/conv_test_minimal_ground_truth
11b9611 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Tinkering with convolultion tests
3fc3b53 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Fixed upstream merge
864998c 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Default convolution tests are robust, and it passes
df645ea 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Added multiple impulse testing for conv default
2202784 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Merge remote-tracking branch 'upstream/main' into feature/conv_test_m…
6a3bb15 
…inimal_ground_truth_next

Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Removed debug prints, spelling errors
9118d8d 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino
Removed unused test files, fixed cmake
c61fcee 
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino blackencino requested a review from a team as a code owner November 5, 2025 04:31
@blackencino blackencino requested review from fwilliams, harrism and sifakis and removed request for harrism November 5, 2025 04:31
@blackencino
Fixed the not-implemented checks
5f71351 
Signed-off-by: Christopher Horvath <[email protected]>
sifakis
sifakis approved these changes Nov 5, 2025
View reviewed changes
Copy link

@sifakis sifakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@blackencino blackencino merged commit 112a017 into openvdb:main Nov 5, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sifakis sifakis sifakis approved these changes

@fwilliams fwilliams Awaiting requested review from fwilliams

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blackencino @sifakis