Skip to content

Conversation

@matthewdcong
Copy link
Contributor

  1. Quotes are required for the TORCH_CUDA_ARCH_LIST so bash doesn't only pick up the first arch. Add that to the -h printout for ./build.sh.
  2. Update the README to use --cuda-arch-list instead of setting TORCH_CUDA_ARCH_LIST.

@matthewdcong matthewdcong requested a review from a team as a code owner November 12, 2025 16:16
@matthewdcong matthewdcong force-pushed the fix_cuda_arch_list_doc branch from de02ae5 to 9851966 Compare November 12, 2025 16:16
Copy link
Contributor

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! If it's not hard, it might also be good to support the ENV variable. That way one can set it in their shell so it can be reused.

@harrism harrism added bug Something isn't working cmake/build Issues related to building and CMake labels Nov 12, 2025
@harrism harrism added this to fVDB Nov 12, 2025
@matthewdcong matthewdcong force-pushed the fix_cuda_arch_list_doc branch 2 times, most recently from 1e88712 to 18d9d08 Compare November 12, 2025 20:44
@matthewdcong matthewdcong force-pushed the fix_cuda_arch_list_doc branch from 18d9d08 to 952659d Compare November 12, 2025 20:45
@matthewdcong
Copy link
Contributor Author

Thanks! I added support for the environment variable:

./build.sh install -v --cuda-arch-list="8.0;9.0"
Using specified TORCH_CUDA_ARCH_LIST=8.0;9.0

./build.sh install -v
Detecting CUDA architectures via nvidia-smi
Detected CUDA architectures: 12.0+PTX

TORCH_CUDA_ARCH_LIST="8.0;9.0" ./build.sh install -v
Using environment TORCH_CUDA_ARCH_LIST=8.0;9.0

@matthewdcong matthewdcong enabled auto-merge (squash) November 12, 2025 21:00
@matthewdcong matthewdcong merged commit d84276b into openvdb:main Nov 12, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this to Done in fVDB Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cmake/build Issues related to building and CMake

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants