Create and use getMaxSharedMemory utility #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Harris <[email protected]>
harrism
added
enhancement
Signed-off-by: Mark Harris <[email protected]>
blackencino
approved these changes
Dec 8, 2025
Contributor
blackencino
left a comment
blackencino
left a comment
There was a problem hiding this comment.
One spelling change request, one nudge that you can ignore, otherwise LGTM.
Signed-off-by: Mark Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
cudaDeviceGetPropertiesevery time we launch the GaussianRasterizeBackward kernel. This is expensive (> 1ms per call). This definitely impacted our training time.This PR adds a new utility that uses (faster)
cudaDeviceGetAttributeinstead, and only ever calls it once per device and caches the result.Signed-off-by: Mark Harris [email protected]